-
Notifications
You must be signed in to change notification settings - Fork 2.1k
ENH: Add Dockerfile for development inside a container #1527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I think this is fine for 3.0 |
Thanks for figuring this out @ColCarroll! |
CONTRIBUTING.md
Outdated
|
||
We have provided a Dockerfile which helps for isolating build problems, and local development. | ||
Install [Docker](https://www.docker.com/) for your operating system, clone this repo, then | ||
then run `./scripts/start_container.sh`. This should start a local docker container called `pymc3`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo then then
Since this is just adding new code I think we should merge this into master after the typo is fixed. |
I added an auto-build to docker hub: https://hub.docker.com/r/pymc/pymc3/ (let me know if I should add you to the docker org). So you don't have to build the image anymore, you can just do: |
Brings up the jupyter notebook, but you can't import pymc3. I now realize that this docker image isn't meant to be used by a user, although we could easily extend/change it to do that. |
@twiecki interesting idea. what about building pymc in docker properly (i.e., pip installing it), and having a standalone My worry is that since it is pretty easy to install, the docker image wouldn't be used, so there isn't much upside. |
Yeah, good point. Since we have it working on conda and linux is easy to begin with I agree with your assessment. In any case, we can use the dockerhub for easier debugging of travis problems now. |
This is tweaking #1473 -- test suite works inside the container, and running
. ./scripts/start_container.sh
works on my machine.It is ready to merge -- it does not change existing functionality (or add new features -- it is only for ease of development), but I can start a new 3.1 branch with this if we want to be strict about only bug fixes going into 3.0 @fonnesbeck.