Skip to content

Conversation

ricardoV94
Copy link
Member

@ricardoV94 ricardoV94 commented Oct 9, 2025

Test started failing in recent CI. Also tweaked the Split implementation, the checks can only be done with constant inputs.


📚 Documentation preview 📚: https://pytensor--1646.org.readthedocs.build/en/1646/

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a failing JAX Split test by updating error expectations and refactoring validation logic. The changes ensure that validation checks are only performed when constant inputs are available, preventing runtime errors with traced JAX values.

  • Updated test expectations to match the actual errors thrown by the JAX Split implementation
  • Refactored Split validation to only perform checks when both axis and splits are constant values

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
tests/link/jax/test_tensor_basic.py Updated error type expectations from AttributeError to ConcretizationTypeError
pytensor/link/jax/dispatch/tensor_basic.py Moved validation checks to only run with constant inputs to avoid tracer errors

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link

codecov bot commented Oct 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.65%. Comparing base (92c3b49) to head (3453c6b).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1646   +/-   ##
=======================================
  Coverage   81.65%   81.65%           
=======================================
  Files         232      232           
  Lines       53087    53088    +1     
  Branches     9403     9404    +1     
=======================================
+ Hits        43348    43349    +1     
  Misses       7286     7286           
  Partials     2453     2453           
Files with missing lines Coverage Δ
pytensor/link/jax/dispatch/tensor_basic.py 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jessegrabowski jessegrabowski merged commit d72a289 into pymc-devs:main Oct 9, 2025
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants