Seed logsumexp benchmark tests #185
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also adds missing numba benchmark test Co-authored-by: Brandon T. Willard <brandonwillard@users.noreply.github.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #185 +/- ##
=======================================
Coverage 80.03% 80.03%
=======================================
Files 170 170
Lines 45086 45086
Branches 9603 9603
=======================================
Hits 36085 36085
Misses 6789 6789
Partials 2212 2212 |
twiecki
approved these changes
Jan 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is quite some variability left, so I am not sure this suffices.
I've also seen other benchmark tests "fail", so maybe we just need live with it, or increase the cutoff value.