Fix local_subtensor_rv_lift rewrite bug with vector parameters
#281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardoV94
force-pushed
the
fix_subtensor_rv_lift
branch
from
408a993 to
b99ff82
Compare
ricardoV94
force-pushed
the
fix_subtensor_rv_lift
branch
from
b99ff82 to
e046a9c
Compare
Also allow rewrite to work with multivariate variables, when indexing does not act on support dims.
ricardoV94
force-pushed
the
fix_subtensor_rv_lift
branch
from
e046a9c to
22de86b
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #281 +/- ##
=======================================
Coverage 80.47% 80.47%
=======================================
Files 171 171
Lines 45433 45440 +7
Branches 11094 11095 +1
=======================================
+ Hits 36560 36567 +7
Misses 6640 6640
Partials 2233 2233
|
michaelosthege
approved these changes
Apr 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #230
CC @jessegrabowski