Skip to content

Add missing "f" before format string (memory profiling) #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2023

Conversation

jklw
Copy link
Contributor

@jklw jklw commented Jun 3, 2023

I think this self-explanatory :) Lazily tested by making the same change inplace in the installed package. Example output (the numbers in the first column were missing):

    <Sum apply outputs (bytes)> <Apply outputs shape> <created/inplace/view> <Apply node>

        195504B  [(24438,), (24438,)] c c Elemwise{Composite}(increments, playerDayRatingSDevs {[11.512925...14543837]}, TensorConstant{(1,) of -0.5}, TensorConstant{(1,) of 0...5175704956}, TensorConstant{[ 2.443470..1.9280028]})
        186496B  [(23312,), (23312,)] c c Elemwise{Composite}(Reshape{1}.0)
         97752B  [(24438,)] c Alloc(TensorConstant{0.0}, TensorConstant{24438})
         97752B  [(24438,)] i IncSubtensor{InplaceSet;int64:int64:}(extRatings, Subtensor{int64:int64:}.0, ScalarConstant{0}, ScalarConstant{2081})
...

@ricardoV94
Copy link
Member

Thanks @jklw, running the tests but should be good to go

@codecov-commenter
Copy link

Codecov Report

Merging #327 (526ff46) into main (236a3df) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #327   +/-   ##
=======================================
  Coverage   80.33%   80.33%           
=======================================
  Files         156      156           
  Lines       45403    45403           
  Branches    11108    11108           
=======================================
  Hits        36475    36475           
  Misses       6712     6712           
  Partials     2216     2216           
Impacted Files Coverage Δ
pytensor/compile/profiling.py 75.35% <100.00%> (ø)

@twiecki twiecki merged commit 86ca185 into pymc-devs:main Jun 3, 2023
@ricardoV94 ricardoV94 added the bug Something isn't working label Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants