Skip to content

Fix numba implementation of CumOp when axis is None #420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

ricardoV94
Copy link
Member

Closes #419

@ricardoV94 ricardoV94 added bug Something isn't working numba labels Aug 24, 2023
@ricardoV94 ricardoV94 changed the title Fix CumOp Numba implementation when axis is None Fix numba implementation of CumOp when axis is None Aug 24, 2023
@ricardoV94 ricardoV94 requested a review from twiecki August 24, 2023 10:18
@codecov-commenter
Copy link

Codecov Report

Merging #420 (6774af4) into main (9a5deee) will increase coverage by 0.01%.
The diff coverage is 88.23%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #420      +/-   ##
==========================================
+ Coverage   80.79%   80.81%   +0.01%     
==========================================
  Files         156      156              
  Lines       45462    45466       +4     
  Branches    11132    11133       +1     
==========================================
+ Hits        36732    36744      +12     
+ Misses       6522     6516       -6     
+ Partials     2208     2206       -2     
Files Changed Coverage Δ
pytensor/link/numba/dispatch/extra_ops.py 95.51% <85.71%> (+3.73%) ⬆️
pytensor/tensor/extra_ops.py 88.53% <100.00%> (ø)
pytensor/tensor/var.py 87.76% <100.00%> (ø)

@ricardoV94 ricardoV94 merged commit 6c3e757 into pymc-devs:main Aug 24, 2023
@ricardoV94 ricardoV94 deleted the fix_numba_cumop branch August 24, 2023 13:01
@ricardoV94 ricardoV94 changed the title Fix numba implementation of CumOp when axis is None Fix numba implementation of CumOp when axis is None Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working numba
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Numba error in CumOp
3 participants