Skip to content

Rename module pytensor.tensor.var to pytensor.tensor.variable #424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 1, 2023

Conversation

purna135
Copy link
Member

Fixes #421
Rename pytensor.tensor.var to pytensor.tensor.variable

Question:
do we require implementing a custom import mechanism for the module var along with issuing a deprecation warning to maintain backward compatibility?

@ricardoV94
Copy link
Member

do we require implementing a custom import mechanism for the module var along with issuing a deprecation warning to maintain backward compatibility?

That would be great

@codecov-commenter
Copy link

Codecov Report

Merging #424 (2ab07fe) into main (288a3f3) will increase coverage by 0.00%.
The diff coverage is 88.37%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #424   +/-   ##
=======================================
  Coverage   80.77%   80.78%           
=======================================
  Files         156      157    +1     
  Lines       45571    45575    +4     
  Branches    11152    11152           
=======================================
+ Hits        36812    36816    +4     
  Misses       6552     6552           
  Partials     2207     2207           
Files Changed Coverage Δ
pytensor/link/basic.py 87.34% <ø> (ø)
pytensor/tensor/type.py 94.48% <ø> (ø)
pytensor/tensor/variable.py 87.76% <87.76%> (ø)
pytensor/link/jax/dispatch/subtensor.py 88.13% <100.00%> (ø)
pytensor/scan/op.py 84.71% <100.00%> (ø)
pytensor/scan/rewriting.py 79.94% <100.00%> (ø)
pytensor/scan/utils.py 87.52% <100.00%> (ø)
pytensor/sparse/basic.py 82.49% <100.00%> (ø)
pytensor/tensor/basic.py 88.59% <100.00%> (ø)
pytensor/tensor/conv/abstract_conv.py 76.13% <100.00%> (ø)
... and 17 more

@ricardoV94 ricardoV94 merged commit 6d3c756 into pymc-devs:main Sep 1, 2023
@ricardoV94
Copy link
Member

Thanks @purna135

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename module pytensor.tensor.var to pytensor.tensor.variable
4 participants