Replace usage of sys.stdout.encoding with sys.getdefaultencoding()
#617
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some environments, `sys.stdout.encoding` may return `None`. This is encountered when knitting an rmarkdown document using the reticulate engine. In that context, `sys.stdout` is replaced with a `StringIO()` object to capture all output. `StringIO().encoding` returns `None` closes rstudio/reticulate#1508
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #617 +/- ##
=======================================
Coverage 80.80% 80.80%
=======================================
Files 162 162
Lines 46743 46743
Branches 11419 11419
=======================================
Hits 37770 37770
Misses 6731 6731
Partials 2242 2242
|
twiecki
approved these changes
Jan 27, 2024
lucianopaz
approved these changes
Jan 27, 2024
There was a problem hiding this comment.
Thanks @t-kalinowski! I had no idea that sys.stdout could end up being a StringIO outside of the scope of tests. This looks much better.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an error encountered when importing
pymcin a rmarkdown document code chunk.In that context,
sys.stdoutis replaced with aStringIO()object to capture all output, andsys.stdout.encodingreturnsNone, raising an exception.closes rstudio/reticulate#1508
Description
Related Issue
Checklist
Type of change