-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement tensor.special.logit
helper
#645
Conversation
Looks pretty good, left just a cosmetic suggestion to the test |
Pre-commit is failing though |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks !
tensor.special.logit
helper
@ricardoV94 |
Test is failing on float32, you can reproduce by adding this snippet at the top of the test file: import pytensor
pytensor.config.floatX = "float32" Probably just means you need to cast |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #645 +/- ##
==========================================
- Coverage 80.83% 80.82% -0.01%
==========================================
Files 162 162
Lines 46797 46814 +17
Branches 11434 11437 +3
==========================================
+ Hits 37827 37838 +11
- Misses 6722 6725 +3
- Partials 2248 2251 +3
|
Thanks a lot @HarshvirSandhu |
Description
Implement tensor helper equivalent for scipy.special.logit
Related Issue
scipy.special.logit
#563Checklist
Type of change