Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broadcasting bug in vectorization of RandomVariables #738

Merged
merged 1 commit into from
May 9, 2024

Conversation

ricardoV94
Copy link
Member

Description

This showed up in #691 and was introduced/not properly handled by #664

We need to explicitly broadcast the new parameters to define the new size!

Checklist

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

Copy link

codecov bot commented Apr 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.81%. Comparing base (044910b) to head (a745bc1).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #738   +/-   ##
=======================================
  Coverage   80.81%   80.81%           
=======================================
  Files         162      162           
  Lines       46805    46813    +8     
  Branches    11451    11453    +2     
=======================================
+ Hits        37825    37834    +9     
  Misses       6730     6730           
+ Partials     2250     2249    -1     
Files Coverage Δ
pytensor/tensor/random/op.py 96.87% <100.00%> (+0.60%) ⬆️
pytensor/tensor/random/utils.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@ricardoV94 ricardoV94 force-pushed the fix_bug_rv_vectorize branch 2 times, most recently from 882cf73 to 6fa873a Compare April 30, 2024 17:58
@ricardoV94 ricardoV94 merged commit caa580b into pymc-devs:main May 9, 2024
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working vectorization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant