Skip to content

Adopt Ruff linter and formatter #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 7, 2023
Merged

Adopt Ruff linter and formatter #268

merged 3 commits into from
Nov 7, 2023

Conversation

juanitorduz
Copy link
Collaborator

Closes #267

@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@codecov Codecov
Copy link

codecov bot commented Nov 7, 2023 •
edited
Loading

Codecov Report

Merging #268 (07732f0) into main (0ef986a) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #268      +/-   ##
==========================================
+ Coverage   74.39%   74.41%   +0.02%     
==========================================
  Files          20       20              
  Lines        1156     1157       +1     
==========================================
+ Hits          860      861       +1     
  Misses        296      296
Files Coverage Δ
causalpy/__init__.py 100.00% <100.00%> (ø)

twiecki
twiecki reviewed Nov 7, 2023
View reviewed changes
drbenvincent
drbenvincent approved these changes Nov 7, 2023
View reviewed changes
Copy link
Collaborator

@drbenvincent drbenvincent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Great that we can get rid of setup.cfg, the root dir is now about as minimal as we can get it.

@drbenvincent @twiecki
Update README.md
07732f0 
Co-authored-by: Thomas Wiecki <thomas.wiecki@gmail.com>
@drbenvincent
Copy link
Collaborator

Nice. Have also swapped out my Black VS Code extension for the Ruff extension

@juanitorduz juanitorduz added devops DevOps related no releasenotes Skipped in automatic release note generation labels Nov 7, 2023
@twiecki twiecki merged commit 7ebab10 into main Nov 7, 2023
@twiecki twiecki deleted the ruff_issue_267 branch November 7, 2023 10:43
@drbenvincent drbenvincent mentioned this pull request Nov 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twiecki twiecki twiecki left review comments

@drbenvincent drbenvincent drbenvincent approved these changes

Assignees
No one assigned
Labels
devops DevOps related no releasenotes Skipped in automatic release note generation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ruff linter and formater
3 participants
@juanitorduz @drbenvincent @twiecki