Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add slack notifier #3002

Merged
merged 7 commits into from Aug 12, 2017
Merged

Add slack notifier #3002

merged 7 commits into from Aug 12, 2017

Conversation

p0psicles
Copy link
Contributor

@p0psicles p0psicles commented Aug 11, 2017

  • PR is based on the DEVELOP branch
  • Don't send big changes all at once. Split up big PRs into multiple smaller PRs that are easier to manage and review
  • Read the contribution guide

TODO:

  • Modify the sprite and add the css for the slack icon.

#2345

@pymedusa pymedusa deleted a comment Aug 11, 2017
@fernandog
Copy link
Contributor

@neoatomic what tool do you use to edit/add sprites?

@neoatomic
Copy link
Contributor

neoatomic commented Aug 11, 2017

@fernandog Nothing special really. Just Paint.net and the copy/past, resize function. ;)
And off course check that the size/start pixel is the same as in the css code for the sprite.

* Added padding to create some space between the icon and the h3/a.
* Added padding to create some space between the .component-group-desc.
@p0psicles p0psicles added this to the 0.1.15 milestone Aug 12, 2017
@p0psicles p0psicles merged commit 38e6cbf into develop Aug 12, 2017
@p0psicles p0psicles deleted the feature/add-slack-notifier branch August 12, 2017 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants