Skip to content

Fix mypy errors in reactive server #1381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 21, 2023
Merged

Fix mypy errors in reactive server #1381

merged 3 commits into from
Feb 21, 2023

Conversation

alexrudd2
Copy link
Collaborator

Supercedes #1371

It turns out the correct answer was, in fact, cleaner code instead of trying to abuse mypy. :)

alexrudd2 and others added 2 commits February 21, 2023 13:48
@alexrudd2 alexrudd2 mentioned this pull request Feb 21, 2023
Closed
2 tasks
@alexrudd2 alexrudd2 requested a review from janiversen February 21, 2023 20:02
janiversen
janiversen approved these changes Feb 21, 2023
View reviewed changes
Copy link
Collaborator

@janiversen janiversen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Simplifying code is a special art 🚀

@janiversen janiversen added this to the Version 3.2 milestone Feb 21, 2023
@janiversen janiversen merged commit 4015e3e into dev Feb 21, 2023
@janiversen janiversen deleted the mypy-reactive-2 branch February 21, 2023 20:17
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@janiversen janiversen janiversen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexrudd2 @janiversen