New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for persistent cache regions #182

Merged
merged 6 commits into from Nov 10, 2015

Conversation

Projects
None yet
2 participants
@sdrave
Member

sdrave commented Nov 10, 2015

Cache regions are marked as persistent or not. Non-persistent cache regions are cleared at program exit. State ids are automatically generated when persistent cache regions are selected.

This addresses #121, #180.

sdrave added some commits Nov 10, 2015

[core.cache] cleanup of CacheableInterface
- make cache_region an attribute
- let default cache region be None
- auto generate sid for persistent regions in enable_caching
[core.cache] use sid for cache key only for persistent regions
and generate the sid if it has not already been computed.
@ftalbrecht

This comment has been minimized.

Member

ftalbrecht commented Nov 10, 2015

Looks good to me!

sdrave added a commit that referenced this pull request Nov 10, 2015

Merge pull request #182 from pymor/persistent_regions
Add support for persistent cache regions

@sdrave sdrave merged commit 158ae90 into master Nov 10, 2015

2 of 3 checks passed

QuantifiedCode We found 2 new issue(s), merge with caution!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@renefritze renefritze deleted the persistent_regions branch Nov 12, 2015

@sdrave sdrave added this to the 0.4 milestone Aug 4, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment