-
Notifications
You must be signed in to change notification settings - Fork 118
From Operator to NumPy operator #238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the nice work! I only have two remarks:
|
I actually noticed that I kept using |
Hi Petar, the code looks good! :-) I agree: The name |
Thx for your work! I agree with Stephan that working with data structures directly (as opposed to operators and vector arrays) means leaving the (current) realm of pyMOR abstractions, and the payment for return shall be the extra instantiation of a |
op | ||
Operator. | ||
format | ||
Format of the resulting |SciPy sparray|. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you really mean sparray
? Never heard of that before. Also, |foo|
is a subtitution in reST (http://www.sphinx-doc.org/en/stable/rest.html#substitutions). We define all our substitions in docs/source/substitutions.py
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops! Thanks for noticing!
Apart from the two minor remarks above, I think this is ready to get merged? |
FYI, I have updated AUTHORS.md and added
to your contributions list. Thanks again for your work! |
See #234