New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NumpyGenericOperator.apply_adjoint #308

Merged
merged 4 commits into from Oct 25, 2016

Conversation

Projects
None yet
3 participants
@pmli
Copy link
Member

pmli commented Oct 20, 2016

See #303

@coveralls

This comment has been minimized.

Copy link

coveralls commented Oct 20, 2016

Coverage Status

Coverage decreased (-0.04%) to 81.315% when pulling 3429909 on np-generic-op-apply-adjoint into dfa475f on master.

@sdrave

This comment has been minimized.

Copy link
Member

sdrave commented Oct 20, 2016

LGTM. While we are at it, we might want to hook up a fixture in pymortests.fixtures.operators.

@pmli

This comment has been minimized.

Copy link
Member Author

pmli commented Oct 21, 2016

Should there also be source_product and range_product?

@sdrave

This comment has been minimized.

Copy link
Member

sdrave commented Oct 21, 2016

Oh, I totally overlooked that. Yes, since it's part of the interface, it would better to add source_product and range_product parameters.

@pmli

This comment has been minimized.

Copy link
Member Author

pmli commented Oct 21, 2016

I have trouble with pickling functions...

@coveralls

This comment has been minimized.

Copy link

coveralls commented Oct 21, 2016

Coverage Status

Coverage decreased (-13.9%) to 67.451% when pulling e3ca9cc on np-generic-op-apply-adjoint into dfa475f on master.

@sdrave

This comment has been minimized.

Copy link
Member

sdrave commented Oct 25, 2016

@pmli, we have two tests for pickling: one that allows our hack to make pickling of arbitrary functions possible and one that tests pickling without this hack. The second variant was applied in pymortests.operators to all possible operators. However, lambdas are not picklable, so this test had to fail. I have improved the pickling tests so that everything should be fine now.

@sdrave

This comment has been minimized.

Copy link
Member

sdrave commented Oct 25, 2016

@pmli, feel free to merge ...

@pmli pmli merged commit 231ce0b into master Oct 25, 2016

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
code-quality/landscape Landscape has completed the code quality check
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@pmli pmli deleted the np-generic-op-apply-adjoint branch Oct 25, 2016

@coveralls

This comment has been minimized.

Copy link

coveralls commented Oct 25, 2016

Coverage Status

Coverage decreased (-0.1%) to 81.25% when pulling dfc64af on np-generic-op-apply-adjoint into dfa475f on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment