Skip to content

Default to POD-Greedy for instationary problems #790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 18, 2019
Merged

Default to POD-Greedy for instationary problems #790

merged 1 commit into from
Oct 18, 2019

Conversation

sdrave
Copy link
Member

@sdrave sdrave commented Oct 17, 2019

Fixes #780.

@sdrave sdrave added pr:change Change in existing functionality rb labels Oct 17, 2019
@sdrave sdrave added this to the 2019.2 milestone Oct 17, 2019
@sdrave sdrave requested a review from pmli October 17, 2019 09:40
@codecov
Copy link

codecov bot commented Oct 17, 2019 •
edited
Loading

Codecov Report

Merging #790 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted Files Coverage Δ
src/pymor/algorithms/greedy.py 84.07% <100%> (+0.28%) ⬆️

@sdrave
Copy link
Member Author

sdrave commented Oct 18, 2019

@pmli, is it ok to merge this?

@sdrave sdrave merged commit 597ca22 into master Oct 18, 2019
@sdrave sdrave deleted the fix_780 branch October 18, 2019 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmli pmli pmli approved these changes

Assignees
No one assigned
Labels
pr:change Change in existing functionality
Projects
None yet
Milestone
2019.2
Development

Successfully merging this pull request may close these issues.

Improve default method in extend_basis
2 participants
@sdrave @pmli