Skip to content

Move domaindescriptions to analyticalproblems.domaindescriptions #855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 16, 2020
Merged

Move domaindescriptions to analyticalproblems.domaindescriptions #855

merged 1 commit into from
Jan 16, 2020

Conversation

sdrave
Copy link
Member

@sdrave sdrave commented Jan 16, 2020

As the next step in my endeavor to cleanup the pymor package, I am moving (and flattening) the domaindescriptions package to an analyticalproblems.domaindescriptions module.

@sdrave
move pymor.domaindescriptions to pymor.analyticalproblems.domaindescr…
7cdfdd9 
…iptions

and flatten package to single module
@sdrave sdrave added pr:change Change in existing functionality builtin-models labels Jan 16, 2020
@sdrave sdrave added this to the 2020.1 milestone Jan 16, 2020
@sdrave sdrave requested review from ftalbrecht and pmli January 16, 2020 11:58
@codecov
Copy link

codecov bot commented Jan 16, 2020 •
edited
Loading

Codecov Report

Merging #855 into master will decrease coverage by <.01%.
The diff coverage is 66.1%.

Impacted Files Coverage Δ
src/pymor/analyticalproblems/text.py 97.36% <100%> (ø) ⬆️
src/pymor/analyticalproblems/burgers.py 100% <100%> (ø) ⬆️
src/pymor/analyticalproblems/thermalblock.py 100% <100%> (ø) ⬆️
...discretizers/builtin/domaindiscretizers/default.py 75.24% <100%> (-0.25%) ⬇️
src/pymor/discretizers/builtin/grids/interfaces.py 83.76% <100%> (ø) ⬆️
...or/discretizers/builtin/domaindiscretizers/gmsh.py 75.26% <100%> (-0.27%) ⬇️
src/pymor/analyticalproblems/helmholtz.py 100% <100%> (ø) ⬆️
src/pymor/analyticalproblems/domaindescriptions.py 72.99% <61.53%> (ø)

@sdrave sdrave merged commit cd319f8 into master Jan 16, 2020
@sdrave sdrave deleted the move_domaindescriptions branch January 16, 2020 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmli pmli pmli approved these changes

+1 more reviewer

@ftalbrecht ftalbrecht ftalbrecht approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
pr:change Change in existing functionality
Projects
None yet
Milestone
2020.1
Development

Successfully merging this pull request may close these issues.
3 participants
@sdrave @ftalbrecht @pmli