can use pl33 filter with dask-backed DataArrays #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocefpaf
reviewed
May 19, 2023
|
|
||
| if isinstance(x, xr.DataArray): | ||
| # find dt in units of hours | ||
| dt = (x.cf["T"][1] - x.cf["T"][0]) * 1e-9 / 3600 |
There was a problem hiding this comment.
This will get clobbered below, no?
There was a problem hiding this comment.
Those other lines use an input dt though, they just assume 1 hour, then modify the dt according to T.
There was a problem hiding this comment.
(though I did test with an hourly dataset so...)
|
Can I add you to the team here so we don't have to "approve and run" the CIs all the time? |
Ok, but can I ping you to review still? |
Sure. I owe some other reviews but this one will be quicker 😬 |
|
@ocefpaf Should I merge? |
|
I'll try to get a new release out soon. Probably next Tuesday. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.