Floating point rounding error when writing c3d

[felixchenier]

Salut Benjamin

In ezc3d/init.py, lines 481 to 487:

                if (
                    nb_analog_frames
                    != self._storage["parameters"]["ANALOG"]["RATE"]["value"][0]
                    / self._storage["parameters"]["POINT"]["RATE"]["value"][0]
                    * nb_point_frames
                ):
                    raise ValueError("Number of frames in the data set must match the analog rate X point frame")

I think there should be accommodation for floating-point rounding error before raising the ValueError. I have some data where nb_analog_frames = 4420, but the calculation of

self._storage["parameters"]["ANALOG"]["RATE"]["value"][0]
                    / self._storage["parameters"]["POINT"]["RATE"]["value"][0]
                    * nb_point_frames

gives 4420.000000000001.

So I get a ValueError instead of successfully saving the c3d. In my view this is only a floating-point difference and the function should go on with saving anyway. I could modify it myself and do a PR, but I'm not sure, is this code autogenerated or it's manually maintained?

Thanks

[felixchenier]

In any case, changing these lines to

                if nb_analog_frames != round(
                    self._storage["parameters"]["ANALOG"]["RATE"]["value"][0]
                    / self._storage["parameters"]["POINT"]["RATE"]["value"][0]
                    * nb_point_frames
                ):

solves the problem.

[pariterre]

Hi @felixchenier
The code is manually generated so changing it makes senses :)
I think you can PR this modification :)

Thanks!