Small Bug Fixes #250
Merged
Small Bug Fixes #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #250 +/- ##
=======================================
Coverage 96.67% 96.67%
=======================================
Files 30 30
Lines 5297 5297
=======================================
Hits 5121 5121
Misses 176 176 Continue to review full report at Codecov.
|
pariterre
approved these changes
Jun 8, 2022
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @teliason)
pariterre
approved these changes
Jun 8, 2022
There was a problem hiding this comment.
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two small bug fixes,
First: Changed rotations data start parameter from 8 bit BYTE to 16bit WORD. Fixes issue when rotation datastart needs to have value greater than 255.
Second: Removed extra quotes from setup.py which created non valid paths when building.
This change is