Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: action using powershell on Windows #1346

Merged
merged 2 commits into from
Nov 25, 2022

Conversation

henryiii
Copy link
Contributor

@henryiii henryiii commented Nov 22, 2022

Fixes #1338 by using the native GHA shell (powershell) on Windows. Using bash changes the path unexpectedly.

You can see it working for existing projects at https://github.com/pybind/scikit_build_example/actions/runs/3524040183/jobs/5908931400. "pipx run cibuildwheel" was verified to work with meson-python independently.

Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Copy link
Contributor

@joerick joerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That quoting is mad. But it does look like it works!

Let's keep an eye out for stdout/stderr mismatches on Windows. I'm not sure that we can get by without the 2>&1 logic, but maybe we can on Windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support to configure cibuildwheel shell (Github Actions).
2 participants