Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor docs fix #1511

Merged
merged 1 commit into from
Jun 6, 2023
Merged

Minor docs fix #1511

merged 1 commit into from
Jun 6, 2023

Conversation

ianthomas23
Copy link
Contributor

This is a minor docs fix. It looks like it was originally a copy-paste-modify but with the modify stage missing.

Whilst I am here, thanks very much for such a useful project.

Copy link
Contributor

@joerick joerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@@ -550,7 +550,7 @@ a table of items, including arrays.
single values.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed for this PR, but this is not true anymore, pip supports arrays, as long as we don't stop it in cibuildwheel (which I don't think we do), it should just work.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, pip support for multiple config settings with the same key was added in 23.1. Here's a link to the changelog: https://pip.pypa.io/en/stable/news/#v23-1

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That reminds me, this would still be true for 3.6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants