Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflow that updates a vX.Y tag on release #1517

Merged
merged 1 commit into from
Jun 10, 2023
Merged

Conversation

joerick
Copy link
Contributor

@joerick joerick commented Jun 9, 2023

This PR will automatically push an updated vMAJOR.MINOR tag for cibuildwheel. e.g. the tag v2.14 would point to version v2.14.2, until v2.14.3 comes out.

It's implemented using a fork of https://github.com/actions/publish-action , https://github.com/joerick/update-vX.Y-tag-action

Context from discord:

@henryiii:

I've resisted moving vX tags since cibuildwheel adds and removes platforms in minor releases, but what do you think about a moving vX.Y tag to reduce dependabot chatter on patch releases?
Dependabot won't update to a different number of .'s since April 2022, so it would be entirely opt-in.

@joerick
Copy link
Contributor Author

joerick commented Jun 10, 2023

Gonna merge this so i can test it in the upcoming release, hope that's okay with everyone.

@joerick joerick merged commit f35d309 into main Jun 10, 2023
@joerick joerick deleted the major-dot-minor-tag branch June 10, 2023 12:08
@LecrisUT
Copy link

LecrisUT commented Jun 11, 2023

Why not move major tag as well?

About your action, how about enabling issues, making a top level action that calls 2 subactions (see cache action) that update the major and minor version respectively

@henryiii
Copy link
Contributor

henryiii commented Jun 11, 2023

@henryiii:

I've resisted moving vX tags since cibuildwheel adds and removes platforms in minor releases, but what do you think about a moving vX.Y tag to reduce dependabot chatter on patch releases?
Dependabot won't update to a different number of .'s since April 2022, so it would be entirely opt-in.

Specifically, platforms change in v2.X releases, and a user should be aware of those upgrades. Adding a new python version or something like musllinux might break a workflow (probably right before release). Removing a platform (like old CPython) could cause wheels you expect to be there to not be there.

If you don't care about any of this, you might as well be fully unpinned.

@LecrisUT
Copy link

That makes sense. That should be documented in the README.md

lpsinger added a commit to lpsinger/healpy that referenced this pull request Jul 31, 2023
This will eliminate manual dependabot update PRs for patch
releases of cibuildwheel.

See pypa/cibuildwheel#1517
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants