Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: build using 3.12 RC by default #1565

Merged
merged 1 commit into from
Aug 8, 2023
Merged

feat: build using 3.12 RC by default #1565

merged 1 commit into from
Aug 8, 2023

Conversation

henryiii
Copy link
Contributor

@henryiii henryiii commented Aug 7, 2023

Requires #1553.

joerick
joerick approved these changes Aug 7, 2023
View reviewed changes
Copy link
Contributor

@joerick joerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Happy to move quickly on this to a release out and some wheels on PyPI :)

@joerick
Copy link
Contributor

joerick commented Aug 7, 2023

Thanks for the quick work on this @henryiii, and @mayeut on the manylinux upstreams :)

@mayeut
Copy link
Member

mayeut commented Aug 8, 2023

I merged #1553 which was all green.
Rebasing this one & removing draft status.

@henryiii @mayeut
feat: build using 3.12 RC by default
a63e11a 
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@mayeut mayeut marked this pull request as ready for review August 8, 2023 06:30
@minrk minrk mentioned this pull request Aug 8, 2023
Merged
@joerick joerick merged commit 47e5d3c into pypa:main Aug 8, 2023
18 checks passed
mgeplf added a commit to BlueBrain/libsonata that referenced this pull request Aug 16, 2023
@mgeplf
Skip Python 3.12 RC wheel builds
25c44a0 
* it was enabled in cibuildwheel:  pypa/cibuildwheel#1565
* however, we won't be uploading these, so we don't need to build them
  yet.
@mgeplf mgeplf mentioned this pull request Aug 16, 2023
Merged
mgeplf added a commit to BlueBrain/libsonata that referenced this pull request Aug 16, 2023
@mgeplf
Skip Python 3.12 RC wheel builds (#286)
97ebd72 
* it was enabled in cibuildwheel:  pypa/cibuildwheel#1565
* however, we won't be uploading these, so we don't need to build them
  yet.
@henryiii henryiii deleted the henryiii/feat/312rc branch June 6, 2024 15:19
@EwoutH
Copy link
Contributor

EwoutH commented Jul 29, 2024

If everything goes well with the 3.13 rc1 release, we can do this again tomorrow!

This was referenced Aug 1, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joerick joerick joerick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@henryiii @joerick @mayeut @EwoutH