-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: do not use linux32
when unnecessary
#1599
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting. Is this a fix for the '-mnative' error on macOS?
cibuildwheel/oci_container.py
Outdated
container_machine = call( | ||
self.engine.name, "run", "--rm", self.image, "uname", "-m", capture_stdout=True | ||
).strip() | ||
if container_machine not in {"x86_64", "aarch64"}: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i686 is the only 32-bit arch so far, I think. Perhaps it would be easier to match that directly?
No, it's a fix for a deadlock following a call to linux32:
It's definitely used on run, the program specified via run is passed to the entrypoint. I'll check it's passed via create also and add a test for this. Turning this into draft until I get time to address all comments. |
Ah, perhaps I am confused about the difference between CMD and ENTRYPOINT. |
I checked https://docs.docker.com/engine/reference/commandline/create/ and since the ENTRYPOINT can be overridden (same as with run), it's used. |
Reaching disk space limits once again. I'll add different commits to free some space. |
cfd8996
to
991de88
Compare
edit: this is now fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me!
This frees up some space preventing reaching GHA disk space limits.
991de88
to
0ccf1dc
Compare
Co-authored-by: Joe Rickerby <joerick@mac.com>
The
linux32
command is always used for linux i686.This makes cross building from macOS arm64 impossible at the moment (might depend on docker configuration).
This PR proposes to check the architecture seen inside the container before using (or not) the
linux32
command.