Add support for GitHub Actions #194

mayeut · 2019-11-05T22:47:33Z

Draft:

basic support (linux, macOS, windows 3.6, 3.7, 3.8)
python 2.7 on windows
python 3.5 on windows
documentation update

Closes #159

Here's a summary of python versions / CI providers used to test cibuildwheel after this PR:

	2.7	3.5	3.6	3.7	3.8
windows	AppVeyor	TravisCI		GitHub	Azure
linux	TravisCI + CircleCI	TravisCI	CircleCI	TravisCI + GitHub	Azure
macOS	CircleCI		TravisCI	CircleCI + GitHub	Azure

YannickJadoul · 2019-11-06T17:43:00Z

Woohoo, great, @mayeut!

mayeut · 2019-11-09T09:13:33Z

Python 3.5 on Windows works after patching distutils. I'm trying to identify if there was a regression in setuptools to signal that at setuptools rather than patching distutils.

mayeut · 2019-11-09T09:14:57Z

macOS 10.14 support dropped in GitHub actions, only 10.15 is supported. This will require to build x86_64 only wheels. Waiting for #156 / #202 to land to see how to manage that.

.github/workflows/test.yml

azure-pipelines.yml

joerick

Keen to get this in! Just docs to go? I'm happy to help out if you like, it should just be a sample config and a few updates here and there?

cibuildwheel/windows.py

mayeut · 2019-11-20T06:54:27Z

Just docs to go?

Still blocking are also #156, #202 and #220 since GH is using macOS 10.15

remorses · 2019-11-23T22:01:03Z

Really appreciate your work guys, waiting for this pull request to finally be able to create wheels for my projects on github

filips123 · 2020-03-08T12:27:35Z

@mayeut Is there any update? What needs to be done to properly support GitHub Actions?

joerick · 2020-03-08T13:03:01Z

I meant to say @mayeut, I can see this is a popular feature, I'm happy to take over this PR and write some docs if you don't have time at the moment?

mayeut · 2020-03-08T13:50:25Z

It was missing a patch in setuptools which has been released yesterday.
I updated the docs but the minimal example is still lacking an archive artifacts section.
@joerick, feel free to push on this branch to update the docs if needed.

YannickJadoul · 2020-03-08T14:30:48Z

A quick reminder to check the table in CI.md and add the new CI configuration there. The file was since the start of this PR, and quite a few updates to our own CI have been done.

joerick · 2020-03-08T16:58:45Z

Fantastic, thanks @mayeut! I'll take a good look soon.

joerick

Couple notes; comments inline.

Only other thing I wonder is- should this be the first CI service listed in setup.md, rather than the last? What's your impression of Github Actions, generally? I ask because Azure currently has that spot (because it was the first multi-platform service and has great build times) but I wonder if this might be simpler and have a better DX. Any thoughts @mayeut ?

.github/workflows/test.yml

examples/github-minimal.yml

jlaine · 2020-03-09T23:39:44Z

.github/workflows/test.yml

+      matrix:
+        os: [ubuntu-18.04, windows-latest, macos-latest]
+    steps:
+    - uses: actions/checkout@v1


actions/checkout@v2 seems to be the current version, maybe go with that?

Note that version 2 doesn’t support submodules. Just an aside.

OK, forget my comment then, v1 works :)

jlaine · 2020-03-09T23:41:05Z

examples/github-minimal.yml

+      matrix:
+        os: [ubuntu-18.04, windows-latest, macos-latest]
+    steps:
+    - uses: actions/checkout@v1


same as above, maybe use v2?

jlaine · 2020-03-10T14:10:20Z

One thing which might be worth testing with the provided example is the behaviour if cibuildwheel fails. I have had very confusing experiences with Github Actions on Windows: the default shell is powershell, and it seems exit with a success code despite one or more commands in a multi-line failing. I ended switching over to bash for all platforms to get proper failures on error.

Closes pypa#159

mayeut · 2020-03-10T21:54:31Z

Only other thing I wonder is- should this be the first CI service listed in setup.md, rather than the last? What's your impression of Github Actions, generally? I ask because Azure currently has that spot (because it was the first multi-platform service and has great build times) but I wonder if this might be simpler and have a better DX. Any thoughts @mayeut ?

Not sure it helps you decide the order but just my 2 cents on this:
I was wondering the same thing, let's see how it compares to Azure (mostly build times).
TravisCI now has more platform support but if you're not interested in s390x, aarch64, ppc64le, then I guess Azure/GitHub are faster (probably true especially on macOS where the waiting queue can grow quite fast, also Windows is still BETA at Travis).
I would not recommend AppVeyor today, even though it's now multipatform, because of build times with one "parallel" job.

henryiii · 2020-03-10T21:58:20Z

A couple more cents: One nice feature of GHA is no special setup/permissions. Azure seems to always be a bit of a headache to get more than one collaborator on because it has a separate repo and permissions model. The performance is generally very similar (since they are pretty much the same platform in the backend). Azure is more powerful (manual build triggers, release pipelines).

joerick · 2020-03-10T23:26:27Z

Thanks both. I'm leaning towards putting it at the top for the reasons you describe.

This PR looks ready to me! Any more comments before we merge?

YannickJadoul · 2020-03-11T11:20:29Z

Minor detail, but we could eliminate CircleCI running on Python 3.7 on macOS, since it's already running on Python 3.6 anyway.

joerick · 2020-03-12T09:26:06Z

Thanks all! I'll try to get a release out with this very soon!

joerick · 2020-03-12T20:02:58Z

Released as 1.3.0!

mayeut force-pushed the github-workflows branch 2 times, most recently from ed22fc7 to a42d97e Compare November 6, 2019 06:48

mayeut commented Nov 9, 2019

View reviewed changes

.github/workflows/test.yml Outdated Show resolved Hide resolved

mayeut commented Nov 9, 2019

View reviewed changes

azure-pipelines.yml Outdated Show resolved Hide resolved

mayeut force-pushed the github-workflows branch 2 times, most recently from d8feda1 to e0f1907 Compare November 9, 2019 18:45

Czaki mentioned this pull request Nov 10, 2019

Assert that build will fail if there is no configuration to build #179

Closed

mayeut force-pushed the github-workflows branch 4 times, most recently from db20951 to f6a7e72 Compare November 11, 2019 12:09

This was referenced Nov 11, 2019

setuptools fails to build a windows python 3.5 C extension on GitHub Actions (msvc) pypa/setuptools#1903

Closed

Use CPython 3.8.0 mechanism to find msvc 14+ pypa/setuptools#1904

Merged

mayeut force-pushed the github-workflows branch 3 times, most recently from 8513808 to 2b7f621 Compare November 14, 2019 21:25

joerick reviewed Nov 17, 2019

View reviewed changes

cibuildwheel/windows.py Outdated Show resolved Hide resolved

mayeut force-pushed the github-workflows branch 2 times, most recently from e44ce72 to 5fb2a5b Compare November 21, 2019 21:51

Czaki mentioned this pull request Nov 23, 2019

macOS on AppVeyor #225

Closed

remorses mentioned this pull request Nov 25, 2019

Provide a manylinux and macos bdist_wheel tartiflette/tartiflette#320

Closed

mbeyeler mentioned this pull request Nov 28, 2019

[TST] Automatic wheelhouse build using Azure Pipelines pulse2percept/pulse2percept#130

Merged

mayeut force-pushed the github-workflows branch 2 times, most recently from 1ecb5e2 to 39471f1 Compare December 2, 2019 10:10

mayeut force-pushed the github-workflows branch from 39471f1 to b6d650f Compare December 12, 2019 20:22

mayeut force-pushed the github-workflows branch from a02bdcd to 5919223 Compare February 27, 2020 20:46

maartenbreddels mentioned this pull request Mar 6, 2020

Nightly/regular releases vaexio/vaex#632

Closed

jlaine mentioned this pull request Mar 7, 2020

[package] generate windows wheels on github actions aiortc/pylsqpack#5

Merged

mayeut force-pushed the github-workflows branch 2 times, most recently from 63db44a to 10084c2 Compare March 7, 2020 23:43

mayeut force-pushed the github-workflows branch from 10084c2 to f84e186 Compare March 8, 2020 13:48

mayeut marked this pull request as ready for review March 8, 2020 13:50

joerick reviewed Mar 9, 2020

View reviewed changes

.github/workflows/test.yml Show resolved Hide resolved

examples/github-minimal.yml Show resolved Hide resolved

jlaine reviewed Mar 9, 2020

View reviewed changes

mayeut force-pushed the github-workflows branch from f84e186 to 4165907 Compare March 10, 2020 21:40

Add support for GitHub Actions

b797430

Closes pypa#159

mayeut force-pushed the github-workflows branch from 626e2b8 to b797430 Compare March 10, 2020 21:45

joerick merged commit 840da16 into pypa:master Mar 12, 2020

mayeut deleted the github-workflows branch April 25, 2020 07:16

astrofrog mentioned this pull request May 6, 2020

Consider using Azure pipelines template for auto-releasing package liberfa/pyerfa#8

Closed

YannickJadoul mentioned this pull request May 6, 2020

Refactor tests to generate projects from template #334

Merged

YannickJadoul mentioned this pull request Jun 2, 2020

example: for GH Actions use action to publish #362

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for GitHub Actions #194

Add support for GitHub Actions #194

mayeut commented Nov 5, 2019 •

edited

Loading

YannickJadoul commented Nov 6, 2019

mayeut commented Nov 9, 2019

mayeut commented Nov 9, 2019 •

edited

Loading

joerick left a comment

mayeut commented Nov 20, 2019

remorses commented Nov 23, 2019

filips123 commented Mar 8, 2020

joerick commented Mar 8, 2020

mayeut commented Mar 8, 2020

YannickJadoul commented Mar 8, 2020

joerick commented Mar 8, 2020

joerick left a comment •

edited

Loading

jlaine Mar 9, 2020

henryiii Mar 10, 2020

jlaine Mar 10, 2020

jlaine Mar 9, 2020

jlaine commented Mar 10, 2020

mayeut commented Mar 10, 2020

henryiii commented Mar 10, 2020

joerick commented Mar 10, 2020

YannickJadoul commented Mar 11, 2020

joerick commented Mar 12, 2020

joerick commented Mar 12, 2020

Add support for GitHub Actions #194

Add support for GitHub Actions #194

Conversation

mayeut commented Nov 5, 2019 • edited Loading

YannickJadoul commented Nov 6, 2019

mayeut commented Nov 9, 2019

mayeut commented Nov 9, 2019 • edited Loading

joerick left a comment

Choose a reason for hiding this comment

mayeut commented Nov 20, 2019

remorses commented Nov 23, 2019

filips123 commented Mar 8, 2020

joerick commented Mar 8, 2020

mayeut commented Mar 8, 2020

YannickJadoul commented Mar 8, 2020

joerick commented Mar 8, 2020

joerick left a comment • edited Loading

Choose a reason for hiding this comment

jlaine Mar 9, 2020

Choose a reason for hiding this comment

henryiii Mar 10, 2020

Choose a reason for hiding this comment

jlaine Mar 10, 2020

Choose a reason for hiding this comment

jlaine Mar 9, 2020

Choose a reason for hiding this comment

jlaine commented Mar 10, 2020

mayeut commented Mar 10, 2020

henryiii commented Mar 10, 2020

joerick commented Mar 10, 2020

YannickJadoul commented Mar 11, 2020

joerick commented Mar 12, 2020

joerick commented Mar 12, 2020

mayeut commented Nov 5, 2019 •

edited

Loading

mayeut commented Nov 9, 2019 •

edited

Loading

joerick left a comment •

edited

Loading