Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS/Windows: Update setuptools #69

Merged
merged 1 commit into from
May 4, 2018

Conversation

mayeut
Copy link
Member

@mayeut mayeut commented May 3, 2018

Update setuptools on macOS/Windows
Not required on linux since the manylinux image is updated frequently

It might help with the issue seen in #63

@mayeut
Copy link
Member Author

mayeut commented May 3, 2018

travis-ci build failing on linux. c.f. #67

@YannickJadoul
Copy link
Member

#67 is merged, so builds should work after rebasing.

But which one should be merged? This one and #68 seem to be addressing the same issue, or did I fail to notice anything?

@YannickJadoul
Copy link
Member

OK, I just read #70 and realized that this update is still necessary on 3.4 and 3.5, so let's merge them both.

@YannickJadoul YannickJadoul merged commit b4c0150 into pypa:master May 4, 2018
@mayeut
Copy link
Member Author

mayeut commented May 4, 2018

@YannickJadoul

This PR address your comment in #63 (comment) but unfortunately, as shown in #70, It won't help for the issue in #63 (I thought it might by misreading changelog of python 3.4 & 3.5 where openSSL is shipped with the installer, but the 32bit only 10.5 installer, not the 10.6+ 32/64 bits installer)

=> This PR won't fix anything, however, macOS & Windows now have a behavior that more closely match the one from manylinux images which are updated frequently.

The only PR that can help #70 is the #68 which updates 2.7 installer from 2.7.14 to 2.7.15 (but that will only fix 2.7 build, not 3.4 or 3.5 builds)

@YannickJadoul
Copy link
Member

@mayeut Sorry, I think I was confusing this with the other one from some time ago, #58 and #57.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants