Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

19.1 circular dependencies #178

Closed
scarabeusiv opened this issue Aug 12, 2019 · 3 comments · Fixed by #179
Closed

19.1 circular dependencies #178

scarabeusiv opened this issue Aug 12, 2019 · 3 comments · Fixed by #179

Comments

@scarabeusiv
Copy link

With the 19.1 release the package now depends on attrs, which in turn depends directly on setuptools. Packaging on its own is a direct dependency of setuptools as well. This means when you are bootstraping the packages it can't be done properly.

Looking at attrs they rely on find_packages and few other tiny features of setuptools 40+ so I don't think it is possible to build them just with distutils...
https://github.com/python-attrs/attrs/blob/master/setup.py

Could maybe tags became optional feature? That would be good enough for us to not hard-require it...
@pradyunsg
Copy link
Member

We can probably drop attrs and change the class in question to a handwritten implementation with slots, if nothing else.

dcermak added a commit to dcermak/packaging that referenced this issue Aug 13, 2019
@dcermak
Drop dependency on attrs
3731ce2 
- replace tags.Tag with a custom implementation instead of using @attr.s
- add a sanity check for __hash__()
- drop attrs from setup.py

This fixes pypa#178
@dcermak dcermak mentioned this issue Aug 13, 2019
Merged
@183amir 183amir mentioned this issue Aug 28, 2019
Closed
@183amir
Copy link

183amir commented Aug 28, 2019

Is there going to be a release with this fix soon?

@pradyunsg
Copy link
Member

There's some discussion on #179.

ales-erjavec added a commit to ales-erjavec/orange-canvas-core that referenced this issue Sep 4, 2019
@ales-erjavec
addons: Remove use of 'packaging'
0c40c52 
due to pypa/packaging#178

Replace its use with pkg_resources.parse_version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Drop dependency on attrs dcermak/packaging
3 participants
@scarabeusiv @pradyunsg @183amir