Logging error when checking for new version of pip. #11309

domdfcoding · 2022-07-26T14:58:31Z

Description

When pip (22.1.2) checked for a new version it failed with an error. It's coming from the following function:

pip/src/pip/_internal/utils/entrypoints.py

Lines 46 to 62 in c4606b3

    
           def get_best_invocation_for_this_pip() -> str: 
        
               """Try to figure out the best way to invoke pip in the current environment.""" 
        
               binary_directory = "Scripts" if WINDOWS else "bin" 
        
               binary_prefix = os.path.join(sys.prefix, binary_directory) 
        
               # Try to use pip[X[.Y]] names, if those executables for this environment are 
        
               # the first on PATH with that name. 
        
               path_parts = os.path.normcase(os.environ.get("PATH", "")).split(os.pathsep) 
        
               exe_are_in_PATH = os.path.normcase(binary_prefix) in path_parts 
        
               if exe_are_in_PATH: 
        
                   for exe_name in _EXECUTABLE_NAMES: 
        
                       found_executable = shutil.which(exe_name) 
        
                       if found_executable and os.path.samefile( 
        
                           found_executable, 
        
                           os.path.join(binary_prefix, exe_name), 
        
                       ): 
        
                           return exe_name

The problem call is to os.path.samefile on line 58, where it compares the output of shutil.which('pip') to <sys.prefix>/bin/pip (in my case /usr/bin/pip). However, on my system, pip is installed to the user site-packages directory (so the binary is at /home/domdf/.local/bin/pip).

The solution is to check whether the file exists before calling samefile.

I have Python 3.7 and 3.9 installed to /usr alongside the system's Python 3.8, and the error is present with all three versions.

Expected behavior

Pip checks for a new version without an error.

pip version

22.1.2

Python version

3.9.13

OS

Ubuntu 20.04

How to Reproduce

pip install pip==22.1.2
pip install pip <- Any package will do.

Output

$ pip install pip
Defaulting to user installation because normal site-packages is not writeable
Requirement already satisfied: pip in ./.local/lib/python3.9/site-packages (22.1.2)
--- Logging error ---
Traceback (most recent call last):
  File "/home/domdf/.local/lib/python3.9/site-packages/pip/_internal/utils/logging.py", line 177, in emit
    self.console.print(renderable, overflow="ignore", crop=False, style=style)
  File "/home/domdf/.local/lib/python3.9/site-packages/pip/_vendor/rich/console.py", line 1752, in print
    extend(render(renderable, render_options))
  File "/home/domdf/.local/lib/python3.9/site-packages/pip/_vendor/rich/console.py", line 1390, in render
    for render_output in iter_render:
  File "/home/domdf/.local/lib/python3.9/site-packages/pip/_internal/utils/logging.py", line 134, in __rich_console__
    for line in lines:
  File "/home/domdf/.local/lib/python3.9/site-packages/pip/_vendor/rich/segment.py", line 245, in split_lines
    for segment in segments:
  File "/home/domdf/.local/lib/python3.9/site-packages/pip/_vendor/rich/console.py", line 1368, in render
    renderable = rich_cast(renderable)
  File "/home/domdf/.local/lib/python3.9/site-packages/pip/_vendor/rich/protocol.py", line 36, in rich_cast
    renderable = cast_method()
  File "/home/domdf/.local/lib/python3.9/site-packages/pip/_internal/self_outdated_check.py", line 130, in __rich__
    pip_cmd = get_best_invocation_for_this_pip()
  File "/home/domdf/.local/lib/python3.9/site-packages/pip/_internal/utils/entrypoints.py", line 58, in get_best_invocation_for_this_pip
    if found_executable and os.path.samefile(
  File "/usr/lib/python3.9/genericpath.py", line 101, in samefile
    s2 = os.stat(f2)
FileNotFoundError: [Errno 2] No such file or directory: '/usr/bin/pip'
Call stack:
  File "/usr/lib/python3.9/runpy.py", line 197, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/usr/lib/python3.9/runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "/home/domdf/.local/lib/python3.9/site-packages/pip/__main__.py", line 31, in <module>
    sys.exit(_main())
  File "/home/domdf/.local/lib/python3.9/site-packages/pip/_internal/cli/main.py", line 70, in main
    return command.main(cmd_args)
  File "/home/domdf/.local/lib/python3.9/site-packages/pip/_internal/cli/base_command.py", line 101, in main
    return self._main(args)
  File "/home/domdf/.local/lib/python3.9/site-packages/pip/_internal/cli/base_command.py", line 223, in _main
    self.handle_pip_version_check(options)
  File "/home/domdf/.local/lib/python3.9/site-packages/pip/_internal/cli/req_command.py", line 148, in handle_pip_version_check
    pip_self_version_check(session, options)
  File "/home/domdf/.local/lib/python3.9/site-packages/pip/_internal/self_outdated_check.py", line 237, in pip_self_version_check
    logger.info("[present-rich] %s", upgrade_prompt)
  File "/usr/lib/python3.9/logging/__init__.py", line 1446, in info
    self._log(INFO, msg, args, **kwargs)
  File "/usr/lib/python3.9/logging/__init__.py", line 1589, in _log
    self.handle(record)
  File "/usr/lib/python3.9/logging/__init__.py", line 1599, in handle
    self.callHandlers(record)
  File "/usr/lib/python3.9/logging/__init__.py", line 1661, in callHandlers
    hdlr.handle(record)
  File "/usr/lib/python3.9/logging/__init__.py", line 952, in handle
    self.emit(record)
  File "/home/domdf/.local/lib/python3.9/site-packages/pip/_internal/utils/logging.py", line 179, in emit
    self.handleError(record)
Message: '[present-rich] %s'
Arguments: (UpgradePrompt(old='22.1.2', new='22.2'),)

Code of Conduct

I agree to follow the PSF Code of Conduct.

The text was updated successfully, but these errors were encountered:

nckturner · 2022-07-27T19:40:22Z

Looks like I have the exact same issue.

$ pip3 install --user boto3 awscli

...redacted...

--- Logging error ---
Traceback (most recent call last):
  File "/home/nic/.local/lib/python3.9/site-packages/pip/_internal/utils/logging.py", line 177, in emit
    self.console.print(renderable, overflow="ignore", crop=False, style=style)
  File "/home/nic/.local/lib/python3.9/site-packages/pip/_vendor/rich/console.py", line 1752, in print
    extend(render(renderable, render_options))
  File "/home/nic/.local/lib/python3.9/site-packages/pip/_vendor/rich/console.py", line 1390, in render
    for render_output in iter_render:
  File "/home/nic/.local/lib/python3.9/site-packages/pip/_internal/utils/logging.py", line 134, in __rich_console__
    for line in lines:
  File "/home/nic/.local/lib/python3.9/site-packages/pip/_vendor/rich/segment.py", line 245, in split_lines
    for segment in segments:
  File "/home/nic/.local/lib/python3.9/site-packages/pip/_vendor/rich/console.py", line 1368, in render
    renderable = rich_cast(renderable)
  File "/home/nic/.local/lib/python3.9/site-packages/pip/_vendor/rich/protocol.py", line 36, in rich_cast
    renderable = cast_method()
  File "/home/nic/.local/lib/python3.9/site-packages/pip/_internal/self_outdated_check.py", line 130, in __rich__
    pip_cmd = get_best_invocation_for_this_pip()
  File "/home/nic/.local/lib/python3.9/site-packages/pip/_internal/utils/entrypoints.py", line 58, in get_best_invocation_for_this_pip
    if found_executable and os.path.samefile(
  File "/usr/lib/python3.9/genericpath.py", line 101, in samefile
    s2 = os.stat(f2)
FileNotFoundError: [Errno 2] No such file or directory: '/usr/bin/pip3.9'
Call stack:
  File "/home/nic/.local/bin/pip3", line 8, in <module>
    sys.exit(main())
  File "/home/nic/.local/lib/python3.9/site-packages/pip/_internal/cli/main.py", line 70, in main
    return command.main(cmd_args)
  File "/home/nic/.local/lib/python3.9/site-packages/pip/_internal/cli/base_command.py", line 101, in main
    return self._main(args)
  File "/home/nic/.local/lib/python3.9/site-packages/pip/_internal/cli/base_command.py", line 223, in _main
    self.handle_pip_version_check(options)
  File "/home/nic/.local/lib/python3.9/site-packages/pip/_internal/cli/req_command.py", line 148, in handle_pip_version_check
    pip_self_version_check(session, options)
  File "/home/nic/.local/lib/python3.9/site-packages/pip/_internal/self_outdated_check.py", line 237, in pip_self_version_check
    logger.info("[present-rich] %s", upgrade_prompt)
  File "/usr/lib/python3.9/logging/__init__.py", line 1446, in info
    self._log(INFO, msg, args, **kwargs)
  File "/usr/lib/python3.9/logging/__init__.py", line 1589, in _log
    self.handle(record)
  File "/usr/lib/python3.9/logging/__init__.py", line 1599, in handle
    self.callHandlers(record)
  File "/usr/lib/python3.9/logging/__init__.py", line 1661, in callHandlers
    hdlr.handle(record)
  File "/usr/lib/python3.9/logging/__init__.py", line 952, in handle
    self.emit(record)
  File "/home/nic/.local/lib/python3.9/site-packages/pip/_internal/utils/logging.py", line 179, in emit
    self.handleError(record)
Message: '[present-rich] %s'
Arguments: (UpgradePrompt(old='22.1.2', new='22.2.1'),)

pradyunsg · 2022-07-27T20:20:38Z

A PR fixing this would be welcome!

timbrown5 · 2022-08-04T08:54:29Z

As a workaround, you can set pip config set global.disable-pip-version-check true to disable the version check when running pip:
https://stackoverflow.com/questions/46288847/how-to-suppress-pip-upgrade-warning

- Add pip install --update pip to avoid logging issue in pip 22.x (pypa/pip#11309 (comment)) - Add text re Paperspace requirements for consistency with other notebook content - Remove reference to Graphcore Bow-IPU under "Build training dataset generator", reference IPU-POD16 (note this assumes the notes about throughput remain true)

We are using Graphcore's containers with Ubuntu 20.04 and a startup command that includes `PIP_DISABLE_PIP_VERSION_CHECK=1` (pypa/pip#11309 (comment)). Removing `pip install --upgrade pip` fixes it to 22.2.2, which works correctly, and gives us consistent usage across the notebooks presented.

domdfcoding added S: needs triage Issues/PRs that need to be triaged type: bug A confirmed bug or unintended behavior labels Jul 26, 2022

pradyunsg added state: awaiting PR Feature discussed, PR is needed and removed S: needs triage Issues/PRs that need to be triaged labels Jul 27, 2022

q0w mentioned this issue Jul 28, 2022

Check if binary_executable exists #11318

Merged

q0w mentioned this issue Aug 19, 2022

PIP Errors installing package when it's not in /usr/bin/php #11387

Closed

1 task

domdfcoding mentioned this issue Aug 31, 2022

entrypoints.py: check if expected_executable exists #11425

Closed

uranusjr closed this as completed in #11318 Aug 31, 2022

github-actions bot locked as resolved and limited conversation to collaborators Oct 1, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Logging error when checking for new version of pip. #11309

Logging error when checking for new version of pip. #11309

domdfcoding commented Jul 26, 2022

nckturner commented Jul 27, 2022 •

edited

Loading

pradyunsg commented Jul 27, 2022

timbrown5 commented Aug 4, 2022

Logging error when checking for new version of pip. #11309

Logging error when checking for new version of pip. #11309

Comments

domdfcoding commented Jul 26, 2022

Description

Expected behavior

pip version

Python version

OS

How to Reproduce

Output

Code of Conduct

nckturner commented Jul 27, 2022 • edited Loading

pradyunsg commented Jul 27, 2022

timbrown5 commented Aug 4, 2022

nckturner commented Jul 27, 2022 •

edited

Loading