-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updating resolvelib version to include new reporter interface #10600
updating resolvelib version to include new reporter interface #10600
Conversation
Needs a news entry for the vendor update, otherwise lgtm. |
We should update the debugging reporter as well. |
I think the idea is to only update vendoring in this PR and do all the pip changes in #10258 (that PR does change the debugging reporter). |
Ah, cool. Ignore me -- I'm just being noisy then. :) |
2f25bb3
to
93f5bf7
Compare
I kinda knew I should add that... but wasn't sure what to write. I should have looked into another vendor upgrade before submitting. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't need to update README, this is fine.
@uranusjr I think I did not make myself clear on this point. ⬆️ |
This is already mentioned in the documentation: https://pip.pypa.io/en/stable/development/contributing/#choosing-the-type-of-news-entry Which I think is more visible than |
Anyway, this should be good since the static checks passed. Let's deal with this in another issue or PR. |
a prerequisite for #10258