Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve our setuptools shim #10723

Closed
wants to merge 1 commit into from

Conversation

pradyunsg
Copy link
Member

Modernise the shim, to account for the Python 3.2+ support matrix.

This also presents clearer error messages on failures, the included
comment helps inform users about why this shim exists and the traceback
now explicitly mentions <pip-setuptools-shim> to make it clearer to
users that this shim exists.

Modernise the shim, to account for the Python 3.2+ support matrix.

This also presents clearer error messages on failures, the included
comment helps inform users about why this shim exists and the traceback
now explicitly mentions `<pip-setuptools-shim>` to make it clearer to
users that this shim exists.
@pradyunsg pradyunsg added type: enhancement Improvements to functionality C: build logic Stuff related to metadata generation / wheel generation labels Dec 10, 2021
@pradyunsg pradyunsg marked this pull request as draft December 10, 2021 16:04
@pradyunsg
Copy link
Member Author

I don't think we should merge this until we land #10703 and another round of changes to improve our subprocess error presentation (from #10421).

@pradyunsg
Copy link
Member Author

Closing this out, since it's a part of #10795.

@pradyunsg pradyunsg closed this Jan 14, 2022
@pradyunsg pradyunsg deleted the better-setuptools-shim branch January 14, 2022 10:41
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
C: build logic Stuff related to metadata generation / wheel generation type: enhancement Improvements to functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant