Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove resolved_revision from DirectUrl VcsInfo #10870

Merged
merged 1 commit into from
Apr 18, 2022

Conversation

sbidoul
Copy link
Member

@sbidoul sbidoul commented Feb 1, 2022

Although resolved_revision it is part of PEP 610, it is currently not implemented in pip, so remove it from the code base to avoid confusion.

@sbidoul sbidoul requested a review from uranusjr February 1, 2022 09:20
@sbidoul sbidoul added the skip news Does not need a NEWS file entry (eg: trivial changes) label Feb 1, 2022
Copy link
Member

@uranusjr uranusjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now everyhting make sense!

Altough resolved_revision it is part of PEP 610, it is currently not
implemented in pip, so remove it from the code
base to avoid confusion.
@sbidoul sbidoul force-pushed the rm-pep610-resolved_revision-sbi branch from 222774d to bc0f4c3 Compare April 18, 2022 11:56
@uranusjr uranusjr added this to the 22.1 milestone Apr 18, 2022
@sbidoul sbidoul merged commit c247ddc into pypa:main Apr 18, 2022
@sbidoul sbidoul deleted the rm-pep610-resolved_revision-sbi branch April 18, 2022 13:00
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
skip news Does not need a NEWS file entry (eg: trivial changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants