Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tar/zip unpack changes #1146

Merged
merged 1 commit into from
Aug 19, 2013
Merged

tar/zip unpack changes #1146

merged 1 commit into from
Aug 19, 2013

Conversation

qwcode
Copy link
Contributor

@qwcode qwcode commented Aug 17, 2013

fixes for #1133 and #317

the changes:

so the net result:

archive members are written based on system defaults and umask (i.e. permissions are not preserved), except that regular file members with any execute permissions (user, group, or world) have the equivalent of "chmod +x" applied after being written. Note that for windows, any execute changes using os.chmod are no-ops per the python docs.

Note: this is different than setuptools, which just preserves all permissions.

class _Octal(object):
"""
a py2/py3 compatible way to represent octal (rather than directly with ints or hex)
e.g. _Octal()._0111 would be the equivalent of 0111 in py2 and 0o111 in py3
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, "0o111" works in py2 as well. I'll take this out and reshuffle tomorrow.

qwcode added a commit that referenced this pull request Aug 19, 2013
@qwcode qwcode merged commit d399789 into pypa:1.4.X Aug 19, 2013
@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Jun 5, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jun 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-locked Outdated issues that have been locked by automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant