New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tar/zip unpack changes #1146

Merged
merged 1 commit into from Aug 19, 2013

Conversation

Projects
None yet
1 participant
@qwcode
Contributor

qwcode commented Aug 17, 2013

fixes for #1133 and #317

the changes:

  • for zips, removed the code that was added in 1.4 that preserved all permissions (fixes #1133)
  • for zips and tars, regular files with any execute perms, now effectively get chmod +x (fixes #317 you can install ctypes now)

so the net result:

archive members are written based on system defaults and umask (i.e. permissions are not preserved), except that regular file members with any execute permissions (user, group, or world) have the equivalent of "chmod +x" applied after being written. Note that for windows, any execute changes using os.chmod are no-ops per the python docs.

Note: this is different than setuptools, which just preserves all permissions.

@qwcode

View changes

Show outdated Hide outdated pip/backwardcompat/__init__.py

qwcode added a commit that referenced this pull request Aug 19, 2013

@qwcode qwcode merged commit d399789 into pypa:1.4.X Aug 19, 2013

1 check passed

default The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment