Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restrict #egg= fragments to valid PEP 508 names #11617

Merged
merged 12 commits into from
Dec 28, 2022
Merged

Restrict #egg= fragments to valid PEP 508 names #11617

merged 12 commits into from
Dec 28, 2022

Commits on Nov 22, 2022

  1. Restrict #egg= fragments to valid PEP 508 names 

    This should help reduce user confusion about what can go in a URI's
egg fragment.

Fixes pypa#11567.

Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Nov 22, 2022
    Configuration menu
    Copy the full SHA
    98aa8b5 View commit details
    Browse the repository at this point in the history

  2. models/link: reuse pyparsing + requirements combinators for egg fragment 

    This should now be consistent with existing tests (without establishing
that those tests are actually well-specified).

Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Nov 22, 2022
    Configuration menu
    Copy the full SHA
    4af0984 View commit details
    Browse the repository at this point in the history

  3. topics/vcs-support: clarify the egg fragment's syntax 

    This doesn't actually address the semantics of extras in the
egg fragment.

Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Nov 22, 2022
    Configuration menu
    Copy the full SHA
    e267126 View commit details
    Browse the repository at this point in the history

  4. models/link: make egg fragment evaluation eager 

    This should prevent us from accepting malformed egg fragments
that are shadowed by other parts of the requirement specifier.

Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Nov 22, 2022
    Configuration menu
    Copy the full SHA
    3c337a9 View commit details
    Browse the repository at this point in the history

  5. tests: add more Link tests 

    This exercises our expectation that egg fragments don't include version
specifiers and are evaluated eagerly.

Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Nov 22, 2022
    Configuration menu
    Copy the full SHA
    227fbee View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2022

  1. Merge branch 'main' into ww/restrict-egg-fragement

    @woodruffw
    woodruffw authored Dec 3, 2022
    Configuration menu
    Copy the full SHA
    61205c1 View commit details
    Browse the repository at this point in the history

  2. topics/vcs-support: re-qualify egg fragment behavior 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    3b9abbc View commit details
    Browse the repository at this point in the history

  3. src, tests: use deprecation instead of hard error for egg fragments 

    This turns invalid egg fragments into a soft error, with a scheduled
deprecation period of two releases.

Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    464d166 View commit details
    Browse the repository at this point in the history

  4. tests: fix comment 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    d9502ff View commit details
    Browse the repository at this point in the history

  5. news: add entry 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    6309748 View commit details
    Browse the repository at this point in the history

  6. news: recategorize entry 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    76cff14 View commit details
    Browse the repository at this point in the history

Commits on Dec 28, 2022

  1. Merge branch 'main' into ww/restrict-egg-fragement

    @woodruffw
    woodruffw authored Dec 28, 2022
    Configuration menu
    Copy the full SHA
    64fe223 View commit details
    Browse the repository at this point in the history