-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor per requirement options #11876
Merged
sbidoul
merged 4 commits into
pypa:main
from
sbidoul:refactor-per-req-global-hash-options-sbi
Mar 27, 2023
Merged
Refactor per requirement options #11876
sbidoul
merged 4 commits into
pypa:main
from
sbidoul:refactor-per-req-global-hash-options-sbi
Mar 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbidoul
added
the
skip news
Does not need a NEWS file entry (eg: trivial changes)
label
Mar 19, 2023
sbidoul
force-pushed
the
refactor-per-req-global-hash-options-sbi
branch
from
March 19, 2023 15:15
57c983f
to
03b7b18
Compare
sbidoul
added
the
type: maintenance
Related to Development and Maintenance Processes
label
Mar 21, 2023
Move the conversion from options to function arguments up the call chain.
For better readability
sbidoul
force-pushed
the
refactor-per-req-global-hash-options-sbi
branch
from
March 27, 2023 12:01
85b48bf
to
82f1ff0
Compare
Rebased to have a green build. |
pradyunsg
approved these changes
Mar 27, 2023
Maybe it should be Sequence[str] instead of Union[str, List[str]]? |
That'd rely on the fact that |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
skip news
Does not need a NEWS file entry (eg: trivial changes)
type: maintenance
Related to Development and Maintenance Processes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some refactoring and readability improvements towards #11325