Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor per requirement options #11876

Merged
merged 4 commits into from
Mar 27, 2023

Conversation

sbidoul
Copy link
Member

@sbidoul sbidoul commented Mar 19, 2023

Some refactoring and readability improvements towards #11325

@sbidoul sbidoul marked this pull request as draft March 19, 2023 14:34
@sbidoul sbidoul added the skip news Does not need a NEWS file entry (eg: trivial changes) label Mar 19, 2023
@sbidoul sbidoul force-pushed the refactor-per-req-global-hash-options-sbi branch from 57c983f to 03b7b18 Compare March 19, 2023 15:15
@sbidoul sbidoul marked this pull request as ready for review March 19, 2023 15:30
@sbidoul sbidoul added this to the 23.1 milestone Mar 19, 2023
@sbidoul sbidoul added the type: maintenance Related to Development and Maintenance Processes label Mar 21, 2023
@sbidoul sbidoul force-pushed the refactor-per-req-global-hash-options-sbi branch from 85b48bf to 82f1ff0 Compare March 27, 2023 12:01
@sbidoul
Copy link
Member Author

sbidoul commented Mar 27, 2023

Rebased to have a green build.

@q0w
Copy link
Contributor

q0w commented Mar 27, 2023

Maybe it should be Sequence[str] instead of Union[str, List[str]]?

@pradyunsg
Copy link
Member

Maybe it should be Sequence[str] instead of Union[str, List[str]]?

That'd rely on the fact that str is a Sequence, and it doesn't clearly indicate that "string" is a valid input -- whereas "string" and ["string", "string2"] are valid inputs here and that's clearly indicated by the union here.

@sbidoul sbidoul merged commit b0a2841 into pypa:main Mar 27, 2023
@sbidoul sbidoul deleted the refactor-per-req-global-hash-options-sbi branch March 27, 2023 13:46
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
skip news Does not need a NEWS file entry (eg: trivial changes) type: maintenance Related to Development and Maintenance Processes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants