Prevent pip install pip install #11898
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaddyGuthridge
force-pushed
the
miguel/fix-pip-install-pip-install
branch
2 times, most recently
from
e713c5c
to
100732c
Compare
|
x-ref pypi/support#451 I'm down to do this, if no one else has concerns. :) |
|
Shouldn't be a problem if |
MaddyGuthridge
force-pushed
the
miguel/fix-pip-install-pip-install
branch
from
d4a2947
to
6629510
Compare
MaddyGuthridge
force-pushed
the
miguel/fix-pip-install-pip-install
branch
from
7e5a089
to
5ff87a3
Compare
MaddyGuthridge
force-pushed
the
miguel/fix-pip-install-pip-install
branch
from
c1e506c
to
275af31
Compare
Co-authored-by: Daniel Hollas <danekhollas@gmail.com>
MaddyGuthridge
force-pushed
the
miguel/fix-pip-install-pip-install
branch
from
275af31
to
e5d795b
Compare
danielhollas
reviewed
Sep 4, 2023
uranusjr
reviewed
Sep 5, 2023
Comment on lines
+274
to
+281
| "\n".join( | ||
| [ | ||
| "Likely incorrect command: pip install pip install ...", | ||
| f"Did you mean \"pip install {' '.join(args[2:])}\"?", | ||
| 'To install the "install" package, run ' | ||
| '"pip install install" separately', | ||
| ] | ||
| ) |
There was a problem hiding this comment.
The join call is unnecessary since you can use implicit string join instead.
uranusjr
reviewed
Sep 5, 2023
| @@ -2560,3 +2560,65 @@ def test_install_pip_prints_req_chain_pypi(script: PipTestEnvironment) -> None: | |||
| f"Collecting python-openid " | |||
| f"(from Paste[openid]==1.7.5.1->-r {req_path} (line 1))" in result.stdout | |||
| ) | |||
|
|
|||
|
|
|||
| def test_prevent_pip_install_pip_install(script: PipTestEnvironment) -> None: | |||
There was a problem hiding this comment.
These two tests can be combined into one with pytest.mark.parametrize.
|
Just closing a loop here: pypi/support#451 was closed, with |
|
It looks like this issue has been resolved. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #11484.
If a user pastes an install command into their terminal, but has already typed
pip installbeforehand, this currently results inpipinstalling theinstallpackage, which is likely never their intention given thatinstallis a nearly useless package to prevent typosquatting.This appears to be a common mistake given that the
installpackage has around 30000 installs on most weekdays.This PR adds a check to prevent users from running
pip install pip install packageandpip install install package, which should hopefully save users some time and frustration, since there won't be a need to follow their mistaken command up with apip uninstall installto rectify their mistake.Note that it is still possible to install the
installpackage usingpip install installby itself or by specifying it as not being the first package.As far as I'm aware, this feature shouldn't require documentation, but I'm happy to write some if required (let me know where since I can't think of a good place for it).
This is my first PR to
pip, so please let me know if there's anything I've overlooked! Thanks!