-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add packse scenarios as pip tests #12580
Closed
notatallshaw
wants to merge
4
commits into
pypa:main
from
notatallshaw:add-packse-scenarios-as-tests
Closed
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Add packse scenarios as pip tests |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,166 @@ | ||
import json | ||
import subprocess | ||
import sys | ||
import time | ||
from typing import Any, Dict, Generator, List | ||
|
||
import pytest | ||
|
||
from tests.lib import PipTestEnvironment | ||
|
||
ambigious_prerelease_resolution = ( | ||
"Spec is ambigious, and uv and pip do not agree: " | ||
"https://github.com/astral-sh/packse/issues/160" | ||
) | ||
requires_different_python_version = ( | ||
"Don't support this test yet with the way pip tests work. Probably " | ||
"need some kind of support from packse, written up a couple of " | ||
"issues that would allow it to be supported: " | ||
"https://github.com/astral-sh/packse/issues/164 " | ||
"https://github.com/astral-sh/packse/issues/163" | ||
) | ||
not_served_as_yanked = ( | ||
"There seems to be an issue with packse serve right now where " | ||
"yanked packages are not showing as yanked in the simple api: " | ||
"https://github.com/astral-sh/packse/issues/165" | ||
) | ||
|
||
EXPECTED_TO_FAIL = { | ||
"example": ( | ||
"Expected solution looks wrong: " | ||
"https://github.com/astral-sh/packse/issues/157" | ||
), | ||
"local-not-used-with-sdist": ( | ||
"Tests that sdist versions are preferred over local versions. " | ||
"Discussed: https://github.com/astral-sh/packse/issues/158. " | ||
"TODO: Find if this is a known issue on pip and/or packaging" | ||
), | ||
"local-transitive-confounding": ( | ||
"Expected solution looks wrong: " | ||
"https://github.com/astral-sh/packse/issues/159" | ||
), | ||
"transitive-prerelease-and-stable-dependency": (ambigious_prerelease_resolution), | ||
"transitive-prerelease-and-stable-dependency-many-versions": ( | ||
ambigious_prerelease_resolution | ||
), | ||
"transitive-package-only-prereleases-in-range-opt-in": ( | ||
ambigious_prerelease_resolution | ||
), | ||
"package-only-prereleases-boundary": ( | ||
"Expected solution is probably wrong: " | ||
"https://github.com/astral-sh/packse/issues/161" | ||
), | ||
"package-prereleases-specifier-boundary": (requires_different_python_version), | ||
"python-greater-than-current": (requires_different_python_version), | ||
"python-greater-than-current-patch": (requires_different_python_version), | ||
"python-greater-than-current-backtrack": (requires_different_python_version), | ||
"python-greater-than-current-excluded": (requires_different_python_version), | ||
"compatible-python-incompatible-override": (requires_different_python_version), | ||
"incompatible-python-compatible-override-unavailable-no-wheels": ( | ||
requires_different_python_version | ||
), | ||
"incompatible-python-compatible-override-no-compatible-wheels": ( | ||
requires_different_python_version | ||
), | ||
"incompatible-python-compatible-override-other-wheel": ( | ||
requires_different_python_version | ||
), | ||
"python-patch-override-no-patch": (requires_different_python_version), | ||
"package-only-yanked": (not_served_as_yanked), | ||
"package-only-yanked-in-range": (not_served_as_yanked), | ||
"requires-package-yanked-and-unyanked-any": (not_served_as_yanked), | ||
"package-yanked-specified-mixed-available": (not_served_as_yanked), | ||
"transitive-package-only-yanked": (not_served_as_yanked), | ||
"transitive-package-only-yanked-in-range": (not_served_as_yanked), | ||
"transitive-yanked-and-unyanked-dependency": (not_served_as_yanked), | ||
} | ||
|
||
|
||
def run_command(command: List[str], cwd: None = None) -> str: | ||
result = subprocess.run(command, cwd=cwd, capture_output=True, text=True) | ||
result.check_returncode() | ||
return result.stdout.strip() | ||
|
||
|
||
@pytest.fixture(scope="session", autouse=True) | ||
def start_packse_server() -> Generator[None, None, None]: | ||
"""Starts the packse server before tests run and ensures it's terminated after.""" | ||
proc = subprocess.Popen( | ||
["packse", "serve", "--host", "127.0.0.1", "--port", "3141"] | ||
) | ||
time.sleep(1) | ||
yield | ||
proc.terminate() | ||
|
||
|
||
def pytest_generate_tests(metafunc: pytest.Metafunc) -> None: | ||
"""Dynamically parameterize tests based on scenarios fetched from packse.""" | ||
|
||
if sys.version_info < (3, 12): | ||
return | ||
|
||
if "scenario" in metafunc.fixturenames: | ||
# Fetch scenarios using packse | ||
run_command(["packse", "fetch", "--force"]) | ||
|
||
# Inspect scenarios using packse | ||
scenarios_json: str = run_command(["packse", "inspect", "scenarios"]) | ||
scenarios = json.loads(scenarios_json) | ||
|
||
# Prepare scenarios for parameterization, marking some as XFAIL | ||
scenarios_for_param = [] | ||
ids_for_param = [] | ||
for scenario in scenarios["scenarios"]: | ||
if scenario["name"] in EXPECTED_TO_FAIL: | ||
mark = pytest.mark.xfail(reason=EXPECTED_TO_FAIL[scenario["name"]]) | ||
scenario_data = pytest.param(scenario, marks=mark) | ||
else: | ||
scenario_data = scenario | ||
scenarios_for_param.append(scenario_data) | ||
ids_for_param.append(scenario["name"]) | ||
|
||
# Parameterize the test function with the prepared scenarios and IDs | ||
metafunc.parametrize("scenario", scenarios_for_param, ids=ids_for_param) | ||
|
||
|
||
@pytest.mark.network | ||
@pytest.mark.skipif(sys.version_info < (3, 12), reason="requires Python 3.12 or higher") | ||
def test_packse_scenario(script: PipTestEnvironment, scenario: Dict[str, Any]) -> None: | ||
"""Dynamically generated test for each packse scenario.""" | ||
expected_satisfiable: bool = scenario["expected"]["satisfiable"] | ||
requirements: list[str] = [r["requirement"] for r in scenario["root"]["requires"]] | ||
|
||
resolver_options = [] | ||
if scenario["resolver_options"]["prereleases"]: | ||
resolver_options.append("--pre") | ||
if scenario["resolver_options"]["no_build"]: | ||
resolver_options.append("--only-binary") | ||
resolver_options.append(",".join(scenario["resolver_options"]["no_build"])) | ||
if scenario["resolver_options"]["no_binary"]: | ||
resolver_options.append("--no-binary") | ||
resolver_options.append(",".join(scenario["resolver_options"]["no_binary"])) | ||
|
||
# Install the package as per the scenario setup | ||
result = script.pip( | ||
"install", | ||
"--index-url=http://127.0.0.1:3141/simple", | ||
*resolver_options, | ||
*requirements, | ||
allow_error=True, | ||
) | ||
|
||
resolution_failure_message = ( | ||
"ERROR: Could not find a version that satisfies the requirement", | ||
"ERROR: ResolutionImpossible", | ||
"ERROR: Cannot install", | ||
"requires a different Python:", | ||
) | ||
|
||
if expected_satisfiable: | ||
assert "ERROR" not in result.stderr | ||
expected_installed = { | ||
p["name"]: p["version"] for p in scenario["expected"]["packages"] | ||
} | ||
script.assert_installed(**expected_installed) | ||
else: | ||
assert any(error in result.stderr for error in resolution_failure_message) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would recommend using the static index packse generates as mentioned in astral-sh/packse#165 (comment) instead — the
serve
command is intended for development purposes.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My concern with that, and maybe it's not justified, is that tests could fail because the scenarios from
packse fetch
&packse inspect
would not align perfectly with the scenarios on the index.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fetch
defaults to pulling the current packse version tag which should always match the corresponding index for that tag. You just need to dopackse inspect --no-hash
since the index is versioned we don't need to include a hash to uniquely identify scenarios.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a long throught about this and my main concern is that if pip wants to add it's own scenarios, or deviate away from packse scenarios (e.g. because they seemingly don't follow the spec astral-sh/packse#161) then using the astra index won't work.
However, for now, I will attempt to implement using the index, and that problem can be worried about in the future.