-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run Python 3.13 CI tests #12620
Run Python 3.13 CI tests #12620
Conversation
Weirdly the Windows runner gave the error:
Maybe I somehow have to force clear cache, as when I go to the manifest I do see Python 3.13 available for Windows x64. I will try and figure it out. Good news though is "tests / 3.13 / Ubuntu" completed it's unit tests: https://github.com/pypa/pip/actions/runs/8669773996/job/23776982113?pr=12620#logs and produced no new errors that I don't see locally. |
cffi doesn't plan on doing a prerelease until at least 3.13 beta: python-cffi/cffi#23 (comment) I might take a look to see if it's possible to do some kind of workaround, but seems unlikely. |
Remember to add |
Thanks! Not sure I would have found that config option. |
I've successfully passed the Python 3.13 tests locally on Linux by sourcing I'm going to mark this ready for review, I'm not sure if pip maintainers will want to wait for |
Looks like 1 actual test failure for Windows, I will investigate once I get a chance |
Found the issue with "test_subdirectory_fragment" fail on Windows in Python 3.13 there is a change in behavior for Python 3.12: >>> os.path.isabs('/tmp/.foo/')
True Python 3.13: >>> os.path.isabs('/tmp/.foo/')
False This change in behavior is intentional: python/cpython#44626 The failing test hard codes the temporary directory, causing this assert to trigger https://github.com/pypa/pip/blob/24.0/src/pip/_internal/cache.py#L40. So the fix is easy, don't hard code the temporary directory in this test. |
This has revealed "test_install_package_with_target" is failing on Windows, I will try and take a look at that soon. |
83da71a
to
d69760b
Compare
I couldn't reproduce "test_install_package_with_target" test failure locally so I tried rebasing and pushing and now all tests have passed, not sure what to make of that, but Python 3.13 is now ready for CI runs. |
d69760b
to
888ae95
Compare
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
888ae95
to
9c08d7d
Compare
Merged with main, now macOS is no longer failing |
Run Python 3.13 in CI tests.
Running locally I found two issues:
May be further issues trying to run on GitHub runners, only one way to find out!