Change the source of truth for pkg_resources' extras
#12711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uranusjr
approved these changes
May 20, 2024
Open
pradyunsg
force-pushed
the
fix-extra-mapping-source-for-pkg-resources
branch
2 times, most recently
from
74d6e8a
to
37adfec
Compare
Instead of relying on the METADATA file, use the `requires.txt` file that pkg_resources uses under the hood to get the "target" extra names to pass into `pkg_resources`.
pradyunsg
force-pushed
the
fix-extra-mapping-source-for-pkg-resources
branch
from
37adfec
to
d993005
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12688
I managed to reproduce it by directly using the relevant versions' sdist.