Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the source of truth for pkg_resources' extras #12711

Merged

Conversation

pradyunsg
Copy link
Member

Closes #12688

I managed to reproduce it by directly using the relevant versions' sdist.

@ichard26 ichard26 mentioned this pull request Jun 6, 2024
@pradyunsg pradyunsg force-pushed the fix-extra-mapping-source-for-pkg-resources branch 2 times, most recently from 74d6e8a to 37adfec Compare June 9, 2024 23:22
@pradyunsg pradyunsg added this to the 24.1 milestone Jun 9, 2024
pradyunsg and others added 2 commits June 10, 2024 07:31
Instead of relying on the METADATA file, use the `requires.txt` file
that pkg_resources uses under the hood to get the "target" extra names
to pass into `pkg_resources`.
@pradyunsg pradyunsg force-pushed the fix-extra-mapping-source-for-pkg-resources branch from 37adfec to d993005 Compare June 10, 2024 06:32
@pradyunsg pradyunsg merged commit ccd7be1 into pypa:main Jun 10, 2024
28 checks passed
@pradyunsg pradyunsg deleted the fix-extra-mapping-source-for-pkg-resources branch June 10, 2024 19:37
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installation error for package with un-normalized extra names in pip 24.1b1
3 participants