Update git tests to not use local partial clones #12721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This works around a git restriction to fix CVE-2024-32004. Users affected by the error `remote: fatal: could not fetch ... from promisor remote` should consider setting the GIT_NO_LAZY_FETCH=0 if they trust the source repo.
|
Should we also add either a news entry or maybe even a comment in the docs explaining the recommendation for users that hit this? |
Since my understanding of the issue is not deep enough, I'm not quite comfortable doing this right now. Perhaps should we wait until we have actual user reports that will help us contextualize the problem. |
|
That's fair. And we can tell them to set the env variable, so it's not as if we're delaying a fix for them in any meaningful way. |
sbidoul
added
skip news
|
🍏 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works around a git restriction to fix CVE-2024-32004.
This change only modifies tests using local git repos to not use partial clones as source repos. Tests using remote git repos continue to work as before.
Users affected by the error
remote: fatal: could not fetch ... from promisor remoteshould consider setting a GIT_NO_LAZY_FETCH=0 env var if they trust the source repo.fixes #12719