Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore --require-virtualenv for check and freeze commands #12842

Merged
merged 1 commit into from
Jul 13, 2024

Conversation

branchvincent
Copy link
Contributor

Since these are read-only commands (like pip list)

Copy link
Member

@ichard26 ichard26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does indeed work, thank you!

@ichard26
Copy link
Member

Ah of course CI is failing because of the flaky tests I introduced. When I come back to the computer in ~two hours, I'll fixup #12839. Sorry about that!

@branchvincent
Copy link
Contributor Author

no worries, thank you both for all your hard work on pip :)

@ichard26 ichard26 added this to the 24.2 milestone Jul 11, 2024
@ichard26
Copy link
Member

@branchvincent could you merge in or rebase on main to pull in the CI fixes that just landed? TIA

@pradyunsg pradyunsg merged commit c2d706f into pypa:main Jul 13, 2024
28 checks passed
@pradyunsg
Copy link
Member

Thanks @branchvincent!

@branchvincent branchvincent deleted the require-virtualenv branch July 13, 2024 23:34
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants