New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for git submodules #421

Closed
wants to merge 1 commit into
base: develop
from

Conversation

Projects
None yet
3 participants
@JordanReiter

JordanReiter commented Dec 30, 2011

No description provided.

@carljm

This comment has been minimized.

Show comment
Hide comment
@carljm

carljm Jan 3, 2012

Contributor

Thanks for the pull request! I think we had discussed this earlier and come down on the side of not supporting submodules, but I'm no longer recalling the reasons for that. @jezdez, do you remember?

In any case, this would need tests.

Contributor

carljm commented Jan 3, 2012

Thanks for the pull request! I think we had discussed this earlier and come down on the side of not supporting submodules, but I'm no longer recalling the reasons for that. @jezdez, do you remember?

In any case, this would need tests.

@jezdez

This comment has been minimized.

Show comment
Hide comment
@jezdez

jezdez Jan 4, 2012

Contributor

I think we basically didn't want to complicate the VCS implementation further by supporting specific features of some VCS but instead only the bare minimum for getting a repo. I strongly believe this rule applies to git submodules, too.

Contributor

jezdez commented Jan 4, 2012

I think we basically didn't want to complicate the VCS implementation further by supporting specific features of some VCS but instead only the bare minimum for getting a repo. I strongly believe this rule applies to git submodules, too.

@JordanReiter

This comment has been minimized.

Show comment
Hide comment
@JordanReiter

JordanReiter Jan 4, 2012

Is this explicit anywhere in the docs? Might be a good idea in case anyone attempts to set up a git-based install that depends on other git submodules. I didn't find out until after I tried to get it to work...

JordanReiter commented Jan 4, 2012

Is this explicit anywhere in the docs? Might be a good idea in case anyone attempts to set up a git-based install that depends on other git submodules. I didn't find out until after I tried to get it to work...

@carljm

This comment has been minimized.

Show comment
Hide comment
@carljm

carljm Jan 4, 2012

Contributor

Yeah, I guess we've had enough trouble keeping the git backend working consistently even for the simple features, we don't really need the burden of supporting more complex features. I've added a note to the docs to clarify this; sorry @JordanReiter for the wasted time and thanks for the contribution.

Contributor

carljm commented Jan 4, 2012

Yeah, I guess we've had enough trouble keeping the git backend working consistently even for the simple features, we don't really need the burden of supporting more complex features. I've added a note to the docs to clarify this; sorry @JordanReiter for the wasted time and thanks for the contribution.

@carljm carljm closed this Jan 4, 2012

@carljm

This comment has been minimized.

Show comment
Hide comment
@carljm

carljm May 28, 2012

Contributor

#289 is the original issue with discussion of this.

Contributor

carljm commented May 28, 2012

#289 is the original issue with discussion of this.

@carljm carljm referenced this pull request May 28, 2012

Closed

Git submodule support #545

@carljm

This comment has been minimized.

Show comment
Hide comment
@carljm

carljm Jun 14, 2012

Contributor

This was fixed in merging #577.

Contributor

carljm commented Jun 14, 2012

This was fixed in merging #577.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment