Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for git submodules #421

Closed
wants to merge 1 commit into from

Conversation

JordanReiter
Copy link

No description provided.

@carljm
Copy link
Contributor

carljm commented Jan 3, 2012

Thanks for the pull request! I think we had discussed this earlier and come down on the side of not supporting submodules, but I'm no longer recalling the reasons for that. @jezdez, do you remember?

In any case, this would need tests.

@jezdez
Copy link
Member

jezdez commented Jan 4, 2012

I think we basically didn't want to complicate the VCS implementation further by supporting specific features of some VCS but instead only the bare minimum for getting a repo. I strongly believe this rule applies to git submodules, too.

@JordanReiter
Copy link
Author

Is this explicit anywhere in the docs? Might be a good idea in case anyone attempts to set up a git-based install that depends on other git submodules. I didn't find out until after I tried to get it to work...

@carljm
Copy link
Contributor

carljm commented Jan 4, 2012

Yeah, I guess we've had enough trouble keeping the git backend working consistently even for the simple features, we don't really need the burden of supporting more complex features. I've added a note to the docs to clarify this; sorry @JordanReiter for the wasted time and thanks for the contribution.

@carljm carljm closed this Jan 4, 2012
@carljm
Copy link
Contributor

carljm commented May 28, 2012

#289 is the original issue with discussion of this.

@carljm carljm mentioned this pull request May 28, 2012
@carljm
Copy link
Contributor

carljm commented Jun 14, 2012

This was fixed in merging #577.

@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Jun 5, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jun 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-locked Outdated issues that have been locked by automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants