-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vendor Update - stdout and stderr of shell should be decoded with system encoding #4932
Vendor Update - stdout and stderr of shell should be decoded with system encoding #4932
Conversation
This is a change to a vendored library - we don't normally patch vendored libraries, but wait for a fix to be released in the library and re-vendor. Could you submit your PR to the |
ec8aaa4
to
4fc7b4c
Compare
I added new version of distro and did "git push -f". Would you review it ? |
Hi @doloopwhile! The way to update a vendored dependency is to update You seem to be missing an update to vendor.txt. |
Fixed UnicodeDecodeError on Linux which system encoding is not UTF-8.
@pradyunsg |
4fc7b4c
to
39b4f3b
Compare
news/4932.bugfix
Outdated
@@ -0,0 +1 @@ | |||
Fixed UnicodeDecodeError on Linux which system encoding is not UTF-8. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This newsfile is not needed. You can just drop this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I will remove it.
This PR looks good to me barring a tiny removal of a single news file. =) |
I removed unnecessary news file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming travis approves, this looks good to me.
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
stdout.decode() and stderr.decode() were called with 'utf-8'.
However, when $LANG is not xx_XX.UTF-8 (e.x. ja_JP.EUCJP),
lsb_release and the shell can outputs "non utf-8" bytes (then, pip aborts).