Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve message when setuptools is missing (PEP 518) #4989

Merged
merged 1 commit into from
Mar 26, 2018
Merged

Improve message when setuptools is missing (PEP 518) #4989

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/pip/_internal/operations/prepare.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,9 +128,13 @@ def prep_for_dist(self, finder):

if 'setuptools' not in build_requirements:
logger.warning(
"This version of pip does not implement PEP 516, so "
"it cannot build a wheel without setuptools. You may need to "
"upgrade to a newer version of pip.")
"%s does not include 'setuptools' as a buildtime requirement "
"in its pyproject.toml.", self.req.name,
)
logger.warning(
"This version of pip does not implement PEP 517 so it cannot "
"build a wheel without setuptools."
)

if not isolate:
self.req.build_env = NoOpBuildEnvironment(no_clean=False)
Expand Down