Fixes #3055 Uninstall causes paths to exceed MAX_PATH limit #6029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Obviously this is not ready to merge yet.) |
|
@pradyunsg @dstufft @pfmoore I think this is ready. I split out the install stage changes to #6030 because I have a question about the direction to take that. |
pradyunsg
approved these changes
Dec 2, 2018
| self.path = os.path.realpath(path) | ||
| break | ||
|
|
||
| if not self.path: |
There was a problem hiding this comment.
This can be a for-else; though I'm not sure if that's best for readability.
for candidate in ...:
try:
...
except:
...
else:
...
break
else:
self.path = os.path.realpath(...)
pradyunsg
added
type: enhancement
|
Waiting on @dstufft to hit merge? |
|
I don't usually merge PRs when I am not super active in the original discussion. There's always a chance that I misunderstand the discussion - obviously, I want to avoid acting based on that. ;) |
|
So, yes. Or @pfmoore. |
|
Thanks, Paul! |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3055 Uninstall causes paths to exceed MAX_PATH limit
Moves files to adjacent directory to avoid creating a deeper path when uninstalling.