-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add instructions on disabling keyring #7200
Conversation
Added documentation about how to disable keyring. Refered pypa/twine#338 for it.
Small edit because of whitespaces
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! Thanks for the PR @Suniti13!
A few minor stylistic suggestions. Happy to merge once they're fixed! ^>^
Added NEWS entry for the issue pypa#6773. Added documentation on how to disable keyring.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be interesting to introduce keyring and its purpose with a sentence and maybe a link before explaining how to disable it ?
Keyring in certain cases can prevent the installing of certain packages and modules | ||
due to authentication errors. In such cases disabling the keyring is recommended. | ||
Keyring can be manually uninstalled but doing so may invalidate other packages that | ||
depends on Keyring. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
depends on Keyring. | |
depend on Keyring. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making this PR, I have been working through some keyring related issues today and I was wondering whether it is discussed at all in the documentation so it is good to see it being added! I am not a maintainer on this project but I made some suggestions anyway, feel free to consult with someone who can hit the merge button if you have any hesitations. Thanks again for your contribution!
Disable Keyring | ||
*************** | ||
|
||
Keyring in certain cases can prevent the installing of certain packages and modules |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps we can indicate how a user could recognize if they are impacted by this issue? The language here is a bit vague, perhaps there are some example warnings (maybe they are ResourceWarning
s or Exception
s that would indicate if keyring
is causing this problem).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By default you don't get any output unfortunately. If you increase the verbosity you are going to read something like Getting credentials from keyring for https://pypi.org/simple
before it get stuck
Disable Keyring | ||
*************** | ||
|
||
Keyring in certain cases can prevent the installing of certain packages and modules |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also I don't think keyring
is mentioned anywhere else in the user guide, maybe before talking about how to turn it off, you could mention that pip doesn't come with keyring but it may try to use it if the user has it installed.
Keyring in certain cases can prevent the installing of certain packages and modules | ||
due to authentication errors. In such cases disabling the keyring is recommended. | ||
Keyring can be manually uninstalled but doing so may invalidate other packages that | ||
depends on Keyring. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
depends on Keyring. | |
depends on keyring. |
@Suniti13 Hi! It would be great if you could respond to the review comments people have left. Once you resolve those suggestions, the maintainers can merge your improvements into the master branch, and once the new documentation is deployed, users can enjoy your improvements! |
Hello! I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the |
Added documentation about how to disable keyring. Refered pypa/twine#338 for it.
Fixes #6773.