Make unpack_* unit tests into functional tests #7478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To be used in some upcoming tests.
This and the next several changes will uncouple the tests from the current implementation, allowing us to factor the actual file download out of `unpack_file_url` and `unpack_http_url`.
This makes the behavior of this function easier to test, since we can use a different file to distinguish the already-downloaded case from the existing-file-hash-failed case.
Reduces coupling between tests and code.
Reduces coupling between tests and code.
Reduces coupling between tests and code.
chrahunt
added
type: refactor
|
Gentle nudge. This is a prereq for extracting the file downloading from |
xavfernandez
approved these changes
Dec 16, 2019
|
Thank you! |
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously our http and file "download" tests were tightly coupled to the implementation. These have been replaced with higher-level tests so that we can change the implementation without losing any coverage.
Progresses #7049.