Add reprod for pre-existing build dir failure #8282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uranusjr
added
the
skip news
uranusjr
force-pushed
the
pre-existing-build-directory-reprod
branch
from
a46de07
to
00ca479
Compare
uranusjr
force-pushed
the
pre-existing-build-directory-reprod
branch
from
00ca479
to
a7b6430
Compare
|
#8283 locates the root cause to the problem: the temp directory pip extracts the sdist into is named after the project, so two different versions of the same project would end up sharing the same source directory. I’m not sure how to fix it, however (without breaking existing stuff). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test is a reproduction of pradyunsg/zazo#19 (comment). Detailed description in the test docstring.