-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Add completion script for powershell #9025
Conversation
/cc @pradyunsg @pfmoore |
6252343
to
29edec5
Compare
Isn’t |
I strongly prefer |
Yes, that makes sense, already updated the option name |
@frostming Any chance you could update this PR? :) |
b238343
to
de109e0
Compare
@pradyunsg Sorry this has been missing from my timeline for a long time. Already rebased. |
Any updates on this feature request? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn’t read the autocompletion code (don’t understand Powershell autocompletion), but otherwise looks good to me.
Thanks @frostming! ^>^ |
This patch adds an option
--posh
topip completion
and the completion works perfectly on my machine(Windows 10 and Powershell 5.1.19041.1)Close #9024
Things need to be polished or discussed:
I pick a common short name--posh
for Powershell, tell me if you prefer the full version:--powershell
.python -m pip
andpip
). It is caused by the fixed name of the backup function. To overcome this, we need a unique name for eachprog
. As a result, we should feed a second value to the template besidesprog
. But since the current implementation works for most cases so I would like to ask for maintainers' opinion on this.